Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix private key authentication with dbshell #79

Merged
merged 2 commits into from
Dec 16, 2023
Merged

Conversation

timgraham
Copy link
Collaborator

Fixes #67

(Pending the release of snowflake-connector-python 3.6.0 which supports the new options.)

@timgraham
Copy link
Collaborator Author

@sfc-gh-hachouraria snowflake-connector-python 3.6.0 was just released. Could you test this?

@sfc-gh-hachouraria
Copy link
Contributor

@sfc-gh-hachouraria snowflake-connector-python 3.6.0 was just released. Could you test this?

Thank you for making these changes @timgraham,

I just tried this branch (dbshell-private-key) and I can confirm that the private_key_file and private_key_file_pwd options work in all cases (usual database interaction from the app and commands such as python3 ./manage.py migrate, as well as the SnowSQL shell launch from python3 ./manage.py dbshell).

Django's general config validation appears to require that I still specify the PASSWORD option so I placed a bogus value in it during these tests.

@timgraham
Copy link
Collaborator Author

Thanks for raising the issue about an inappropriately required PASSWORD. I added a commit to address it.

@sfc-gh-hachouraria
Copy link
Contributor

Thanks for raising the issue about an inappropriately required PASSWORD. I added a commit to address it.

Thank you! I had no idea internal configs already existed for skipping that requirement — Django is brilliant.

Confirming I can completely skip PASSWORD in the config now with this change.

@timgraham timgraham marked this pull request as ready for review December 16, 2023 00:07
@timgraham timgraham merged commit 75b1d0b into master Dec 16, 2023
3 checks passed
@timgraham timgraham deleted the dbshell-private-key branch December 16, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option private_key does not work when launching SnowSQL
2 participants