-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag allowed_values order difference results in repeated apply #1806
Comments
This is also similar to #1498 |
@chrisweis I do have an unrelated question but are you tagging objects based on what system is creating them? I have been thinking about doing it because I think it would be easier to identify what owns an object. |
Hi @culpgrant yes, exactly! I also have other systems that control schema content (FiveTran, Segment, etc). I was experimenting with tags for tracking where object control originates, but I'm starting to think that Snowflake ownership is probably enough (ex: TERRAFORM_ROLE is owner of the objects it controls while DBT_ROLE is owner of other objects it controls). I'm working through the boundary between Terraform and dbt (especially for grants). |
Yes interesting! I had the same idea and then decided that seeing the owner in Snowflake was enough. |
<!-- Feel free to delete comments as you fill this in --> - rework tag resource for v1 - generate asserts and models - deprecate snowflake_tag_masking_policy_association - extract a parser for extracting schema object identifier list <!-- summary of changes --> ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x] acceptance tests <!-- add more below if you think they are relevant --> * [ ] … ## References <!-- issues documentation links, etc --> https://docs.snowflake.com/en/sql-reference/sql/create-tag #1806 #1443 #1394 ## TODO - tag data source - tag association resource - asserting that ALTER MASKING POLICY [ IF EXISTS ] <name> SET TAG doesn't alter the tag and vice-versa - we already unset masking policies from the tags on the tag part, but we're missing this on masking policies part - add acc tests, too
Hi @chrisweis @culpgrant 👋 We've just released v0.99.0 (release, migration guide) in which we reworked tags. This issue should be fixed. Please upgrade to this version and let us know if you have any issues. |
Closing due to inactivity. |
Provider Version
v0.64.0
Terraform Version
v1.4.6
Describe the bug
Somehow the order of the "allowed_values" property of a snowflake_tag resource is resulting in a repetitive modification upon "snowflake apply"
Screenshot for clarification:

Expected behavior
I would expect that either:
My preference would be #2 (if it doesn't harm tag associations) and #1 if tag associations would be harmed.
Code samples and commands
Please add code examples and commands that were run to cause the problem.
My code:
Snowflake's state:
Add any other context about the problem here.
Oddly, when I do a
terraform destroy
and thenterraform apply
it still doesn't resolve this order difference, almost as those the order is being cached somewhere (possibly in Snowflake?)The text was updated successfully, but these errors were encountered: