Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tag resource v1 #3197

Merged
merged 9 commits into from
Nov 20, 2024
Merged

feat: Tag resource v1 #3197

merged 9 commits into from
Nov 20, 2024

Conversation

sfc-gh-jmichalak
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak commented Nov 13, 2024

  • rework tag resource for v1
  • generate asserts and models
  • deprecate snowflake_tag_masking_policy_association
  • extract a parser for extracting schema object identifier list

Test Plan

  • acceptance tests

References

https://docs.snowflake.com/en/sql-reference/sql/create-tag
#1806
#1443
#1394

TODO

  • tag data source
  • tag association resource
  • asserting that ALTER MASKING POLICY [ IF EXISTS ] SET TAG doesn't alter the tag and vice-versa
  • we already unset masking policies from the tags on the tag part, but we're missing this on masking policies part - add acc tests, too

Copy link

Integration tests cancelled for c2d75ccc65dc153f55224176883cf6eeca15ef7b

Copy link

Integration tests failure for 5856b180b92d1dccdaaad0b3a6aee0a51e5ae8ca

Copy link

Integration tests success for 4929fc1c70a6f57debf796373faa05b64bed8b3b

@sfc-gh-jmichalak sfc-gh-jmichalak marked this pull request as ready for review November 14, 2024 15:06
Copy link

Integration tests failure for ad4b1cb763c0921621483dc5e07cc07c75080f58

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review November 18, 2024 09:51
Copy link

Integration tests cancelled for 7bbc30ee170b34300fe16e391f55c1ed8beca484

Copy link

Integration tests failure for c2aedf80ee0eeb3a307ef417bbc1afa306495601

Copy link

Integration tests failure for bdfd7ef290fc1cd342acb04767cfeae28cc2ed41

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review November 20, 2024 10:21
@sfc-gh-jmichalak sfc-gh-jmichalak merged commit 77b3bf0 into main Nov 20, 2024
8 of 9 checks passed
@sfc-gh-jmichalak sfc-gh-jmichalak deleted the tag-resource-v1 branch November 20, 2024 10:54
sfc-gh-jmichalak pushed a commit that referenced this pull request Nov 26, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.99.0](v0.98.0...v0.99.0)
(2024-11-26)


### 🎉 **What's new:**

* Add tags data source
([#3211](#3211))
([8907d9d](8907d9d))
* Tag resource v1
([#3197](#3197))
([77b3bf0](77b3bf0))
* Tasks v1 readiness
([#3222](#3222))
([e2284d9](e2284d9))


### 🔧 **Misc**

* Add support for usage tracking to data sources
([#3224](#3224))
([8210bb8](8210bb8))
* Add usage tracking for the rest of the resources and fix views
([#3223](#3223))
([231f653](231f653))
* Basic object tracking
([#3205](#3205))
([1f0dc94](1f0dc94))
* basic object tracking part 2
([#3214](#3214))
([e44f2e1](e44f2e1))
* Improve tags integration tests
([#3193](#3193))
([7736e0a](7736e0a))
* parser and secret tests
([#3192](#3192))
([5ec9c86](5ec9c86))
* Storage integration with custom protocol
([#3213](#3213))
([a3a44ae](a3a44ae))
* Unskip auth config tests
([#3180](#3180))
([46ab142](46ab142))


### 🐛 **Bug fixes:**

* Small fixes and adjustments
([#3226](#3226))
([9f67457](9f67457))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants