Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Experiment with masking #3232

Closed
wants to merge 26 commits into from
Closed

chore: Experiment with masking #3232

wants to merge 26 commits into from

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Nov 27, 2024 •
edited
Loading

This is the experimental PR to check the masking behavior in GH actions:

  • it works for single line secrets
  • it works for multiline secrets line-by-line (and this is how the masking works)
  • it works explicitly line-by-line if needed (because the above is really poorly documented)

The PR will be closed and the envs will be deleted but it is documented what is needed to set it up.

@github-actions GitHub Actions
Copy link

Integration tests success for 84758eeb121aa5c99051262bc62edeec65032ab9

@github-actions GitHub Actions
Copy link

Integration tests success for 0bc664e72913e9e80bea7ed00e732c5d86490586

@sfc-gh-asawicki sfc-gh-asawicki force-pushed the experiment-with-ci-setup branch from 0bc664e to afb0be6 Compare November 27, 2024 13:20
@github-actions GitHub Actions
Copy link

Integration tests failure for afb0be6dda0976d97557ec5554cb2882ef3ddf5f

@github-actions GitHub Actions
Copy link

Integration tests success for da1f6713e745a33ac1065f948e3da39a92a5e1db

@github-actions GitHub Actions
Copy link

Integration tests success for 3ebac93738e262ea9754d2f168de7e7fa8b39992

@github-actions GitHub Actions
Copy link

Integration tests success for d31130c029cd3d86efa4cf5f969415a222920a53

@github-actions GitHub Actions
Copy link

Integration tests success for 1019903650216f7a04af2598f5b81846930c2467

@github-actions GitHub Actions
Copy link

Integration tests success for b41a48f1dd9b31a81827161935ca7a8663018ea5

@github-actions GitHub Actions
Copy link

Integration tests success for e87c2a3b84576cbae249e44c91cd3495f79b56c6

@github-actions GitHub Actions
Copy link

Integration tests success for cf881392e1c86f5e8be6c23c420afc70af2544bd

@github-actions GitHub Actions
Copy link

Integration tests success for 5a06bfd415d8bf15efa22e79a0489871ec261ab4

@github-actions GitHub Actions
Copy link

Integration tests success for c27ecc622fd2310fc619a98b08048ab095e9fd74

@github-actions GitHub Actions
Copy link

Integration tests success for 6c5aaf36a3da664c0633a217450552b45ba83b04

@github-actions GitHub Actions
Copy link

Integration tests success for cedb16161f6be36712deeba1a42a88500169a5c1

@github-actions GitHub Actions
Copy link

Integration tests failure for 21424a31592f35609103c5a4b3f8ae9b61fb662c

@github-actions GitHub Actions
Copy link

Integration tests success for 26bf305e40ac22a08f9db51a8115b7af7ada4c2e

@github-actions GitHub Actions
Copy link

Integration tests failure for ac4db1577e3f49e7badc8f98d62784a74ee0c969

@github-actions GitHub Actions
Copy link

Integration tests failure for de7e70210370625bc56168dd31780bb785558104

@github-actions GitHub Actions
Copy link

Integration tests failure for 1058ce0e1e8c0634fe1837a903615c288333f4e5

@github-actions GitHub Actions
Copy link

Integration tests failure for 346bcc4f2f28950e8b95815e4e92e88eb9f234b6

@github-actions GitHub Actions
Copy link

Integration tests success for 94faebf0c86c4c60ec8311875ba41e57f5eebc79

@github-actions GitHub Actions
Copy link

Integration tests success for eb167d2c90c2bcdc031b7eef2543542c217bb038

@github-actions GitHub Actions
Copy link

Integration tests success for a206c0cce4d5a3a656de19dcb66c252b04e7d796

@github-actions GitHub Actions
Copy link

Integration tests success for 684e98a9f4ed7907b8c8f1d6fab4c47193511339

@github-actions GitHub Actions
Copy link

Integration tests success for 7a3723d6c466b0a415584644c298a8a2d30053e7

@sfc-gh-asawicki sfc-gh-asawicki mentioned this pull request Nov 28, 2024
Merged
@sfc-gh-asawicki sfc-gh-asawicki changed the title chore: Experiment chore: Experiment with masking Nov 28, 2024
sfc-gh-asawicki added a commit that referenced this pull request Nov 28, 2024
@sfc-gh-asawicki
chore: Apply masking (#3234)
c209a8a 
Based on the:
- experiments here:
#3232
- docs here:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#masking-a-value-in-a-log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-asawicki