chore: Overview of the grant ownership resource #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,7 @@ description: |- | |||
| {{- end }} | |||
| --- | |||
|
|
|||
| ~> **Note** For more details about granting ownership, please visit [`GRANT OWNERSHIP` Snowflake documentation page](https://docs.snowflake.com/en/sql-reference/sql/grant-ownership). | |||
| ~> **Note** For more details about granting ownership, please visit [`GRANT OWNERSHIP` Snowflake documentation page](https://docs.snowflake.com/en/sql-reference/sql/grant-ownership), and our recently published [grant ownership resource overview](https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/guides/grant_ownership_resource_overview). | |||
There was a problem hiding this comment.
Nit: Pls remove recently. Also, use a permalink.
| @@ -0,0 +1,92 @@ | |||
| # Grant ownership summary | |||
|
|
|||
| The [grant\_ownership resource](https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/resources/grant_ownership) was introduced in version 0.88.0. | |||
There was a problem hiding this comment.
Why do we publish it in both directories?
There was a problem hiding this comment.
Technical documentation for consistency with other summary/overview docs, guides directory to be visible in the registry. I can limit to only one if we want it that way.
There was a problem hiding this comment.
we will move stuff around soon. I am for sure against publishing exactly the same doc in both places, we can link one from the other.
There are examples incoming, so maybe they should reside in the guides, and the technical docs part can be just linked with them?
|
Integration tests failure for ea0b3f647662c0fd3290a7956449e1fa7a40721f |
sfc-gh-asawicki
approved these changes
Jan 20, 2025
sfc-gh-jmichalak
approved these changes
Jan 20, 2025
|
Integration tests cancelled for 6a7338c0f6a6b5f5652d018466449e2e67e35052 |
sfc-gh-jcieslak
added a commit
that referenced
this pull request
Jan 20, 2025
## Changes - Add a new grant ownership overview document in - the technical_documentation directory - guides directory that will be published to the registry - added link form the grant_ownership documentation to the guide placed in the registry
sfc-gh-jcieslak
added a commit
that referenced
this pull request
Jan 20, 2025
## Changes - Add a new grant ownership overview document in - the technical_documentation directory - guides directory that will be published to the registry - added link form the grant_ownership documentation to the guide placed in the registry
sfc-gh-jcieslak
added a commit
that referenced
this pull request
Jan 20, 2025
## Changes - Add a new grant ownership overview document in - the technical_documentation directory - guides directory that will be published to the registry - added link form the grant_ownership documentation to the guide placed in the registry
|
Integration tests failure for 145ebea00408a090699784531193ab2122516566 |
sfc-gh-jcieslak
added a commit
that referenced
this pull request
Jan 20, 2025
## Changes - Add a new grant ownership overview document in - the technical_documentation directory - guides directory that will be published to the registry - added link form the grant_ownership documentation to the guide placed in the registry
sfc-gh-jcieslak
added a commit
that referenced
this pull request
Jan 20, 2025
## Changes - Add a new grant ownership overview document in - the technical_documentation directory - guides directory that will be published to the registry - added link form the grant_ownership documentation to the guide placed in the registry
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Jan 21, 2025
🤖 I have created a release *beep* *boop* --- ## [1.0.2](v1.0.1...v1.0.2) (2025-01-20) ### 🔧 **Misc** * Generate ID and ObjectType Show Object Methods ([#3292](#3292)) ([f7ff70a](f7ff70a)) * Generate multiline by default ([#3315](#3315)) ([520bb4c](520bb4c)) * Overview of the grant ownership resource ([#3342](#3342)) ([9f891d6](9f891d6)) * Update docs and migration guide ([#3313](#3313)) ([59e333a](59e333a)) ### 🐛 **Bug fixes:** * Fixes in account parameters ([#3310](#3310)) ([96a1f17](96a1f17)) * Handle optional account fields in the state upgrader correctly ([#3330](#3330)) ([4eae4c8](4eae4c8)), closes [#3332](#3332) * Small fixes ([#3337](#3337)) ([8807839](8807839)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes