-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace get/setSex with get/setGender -> master #105
Open
ovr
wants to merge
8
commits into
master
Choose a base branch
from
heiglandreas-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 15, 2019
-
Replace get/setSex with get/setGender
As explained in #94 it's a good idea to use gender instead of sex. To not break BC the get/setSex are still available but are marked as deprecated. The current functionality works as before. In addition to that it is possible to set `other` as gender and the default now is to return `unknown` instead of NULL.
Configuration menu - View commit details
-
Copy full SHA for 8f43775 - Browse repository at this point
Copy the full SHA 8f43775View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6f183f - Browse repository at this point
Copy the full SHA c6f183fView commit details -
Reinstantiate the SEX_* constants
As they are already used removing them is a BC break that we do not want!
Configuration menu - View commit details
-
Copy full SHA for 8b9b122 - Browse repository at this point
Copy the full SHA 8b9b122View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c2950e - Browse repository at this point
Copy the full SHA 3c2950eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7985cb7 - Browse repository at this point
Copy the full SHA 7985cb7View commit details -
Remove calls to deprecated functions
This removes the calls to get/setSex with the appropriate get/setGender calls. Tests are now again passing
Configuration menu - View commit details
-
Copy full SHA for 7bb7cc3 - Browse repository at this point
Copy the full SHA 7bb7cc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf0bb73 - Browse repository at this point
Copy the full SHA cf0bb73View commit details -
The removed docBlock contains redundant information and was therefore removed
Configuration menu - View commit details
-
Copy full SHA for 59da662 - Browse repository at this point
Copy the full SHA 59da662View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.