Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace get/setSex with get/setGender -> master #105

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Replace get/setSex with get/setGender -> master #105

wants to merge 8 commits into from

Commits on Sep 15, 2019

  1. Replace get/setSex with get/setGender 

    As explained in #94 it's a good idea to use gender instead of sex. 

To not break BC the get/setSex are still available but are marked as deprecated. The current functionality works as before. In addition to that it is possible to set `other` as gender and the default now is to return `unknown` instead of NULL.
    @heiglandreas
    heiglandreas authored Sep 15, 2019
    Configuration menu
    Copy the full SHA
    8f43775 View commit details
    Browse the repository at this point in the history

  2. Fix bugs 

    Such things happen when you try to code in github...
    @heiglandreas
    heiglandreas authored Sep 15, 2019
    Configuration menu
    Copy the full SHA
    c6f183f View commit details
    Browse the repository at this point in the history

  3. Reinstantiate the SEX_* constants 

    As they are already used removing them is a BC break that we do not want!
    @heiglandreas
    heiglandreas authored Sep 15, 2019
    Configuration menu
    Copy the full SHA
    8b9b122 View commit details
    Browse the repository at this point in the history

  4. raise deprecation error when set/getSex is called

    @heiglandreas
    heiglandreas authored Sep 15, 2019
    Configuration menu
    Copy the full SHA
    3c2950e View commit details
    Browse the repository at this point in the history

  5. trigger error when deprecated constants are used

    @heiglandreas
    heiglandreas authored Sep 15, 2019
    Configuration menu
    Copy the full SHA
    7985cb7 View commit details
    Browse the repository at this point in the history

  6. Remove calls to deprecated functions 

    This removes the calls to get/setSex with the appropriate get/setGender
calls. Tests are now again passing
    @heiglandreas
    heiglandreas committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    7bb7cc3 View commit details
    Browse the repository at this point in the history

  7. Fix CS-issues

    @heiglandreas
    heiglandreas committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    cf0bb73 View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary docblock 

    The removed docBlock contains redundant information and was therefore
removed
    @heiglandreas
    heiglandreas committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    59da662 View commit details
    Browse the repository at this point in the history