Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #110: updated flask json import #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HugoGarzaUresti
Copy link

I updated the flask json import so it now matches modern versions of flask. There were some changes made to flask so flask.json.provider and DefaultJSONProvider are no longer named like that.

@michaelyaakoby
Copy link
Member

Thanks and apologize for the delay.
Checking.

Copy link
Member

@michaelyaakoby michaelyaakoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing with:

ImportError: cannot import name 'JSONProvider' from 'flask.json' (/github/home/.cache/pypoetry/virtualenvs/pyctuator-Mk81mOig-py3.9/lib/python3.9/site-packages/flask/json/__init__.py)

See https://github.com/SolarEdgeTech/pyctuator/actions/runs/9598259999/job/27681704650?pr=111#step:7:3109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants