NET-1038 Add symbolic-execution tag to our rules (#4621)

SonarSource · Jan 28, 2025 · 2dc3a33 · 2dc3a33
1 parent 4c6681e
commit 2dc3a33
Show file tree

Hide file tree

Showing 25 changed files with 93 additions and 28 deletions.
diff --git a/rules/S2053/csharp/metadata.json b/rules/S2053/csharp/metadata.json
@@ -1,3 +1,6 @@
 {
-
+  "tags": [
+    "cwe",
+    "symbolic-execution"
+  ]
 }
diff --git a/rules/S2053/vbnet/metadata.json b/rules/S2053/vbnet/metadata.json
@@ -1,3 +1,6 @@
 {
-
+    "tags": [
+        "cwe",
+        "symbolic-execution"
+      ]
 }
diff --git a/rules/S2222/java/metadata.json b/rules/S2222/java/metadata.json
@@ -1,7 +1,3 @@
 {
-  "tags": [
-    "cwe",
-    "multi-threading",
-    "symbolic-execution"
-  ]
+
 }
diff --git a/rules/S2222/metadata.json b/rules/S2222/metadata.json
@@ -14,7 +14,8 @@
   },
   "tags": [
     "cwe",
-    "multi-threading"
+    "multi-threading",
+    "symbolic-execution"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S2259/csharp/metadata.json b/rules/S2259/csharp/metadata.json
@@ -1,3 +1,7 @@
 {
-  "quickfix": "infeasible"
+  "quickfix": "infeasible",
+  "tags": [
+    "cwe",
+    "symbolic-execution"
+    ]
 }
diff --git a/rules/S2259/vbnet/metadata.json b/rules/S2259/vbnet/metadata.json
@@ -1,3 +1,7 @@
 {
-  "quickfix": "infeasible"
+  "quickfix": "infeasible",
+  "tags": [
+    "cwe",
+    "symbolic-execution"
+    ]
 }
diff --git a/rules/S2583/csharp/metadata.json b/rules/S2583/csharp/metadata.json
@@ -1,3 +1,10 @@
 {
-  "quickfix": "targeted"
+  "quickfix": "targeted",
+  "tags": [
+    "cwe",
+    "unused",
+    "suspicious",
+    "pitfall",
+    "symbolic-execution"
+    ]
 }
diff --git a/rules/S2583/vbnet/metadata.json b/rules/S2583/vbnet/metadata.json
@@ -1,3 +1,10 @@
 {
-  "quickfix": "targeted"
+  "quickfix": "targeted",
+  "tags": [
+    "cwe",
+    "unused",
+    "suspicious",
+    "pitfall",
+    "symbolic-execution"
+    ]
 }
diff --git a/rules/S2589/csharp/metadata.json b/rules/S2589/csharp/metadata.json
@@ -1,3 +1,8 @@
 {
-
+    "tags": [
+        "cwe",
+        "suspicious",
+        "redundant",
+        "symbolic-execution"
+      ]
 }
diff --git a/rules/S2589/vbnet/metadata.json b/rules/S2589/vbnet/metadata.json
@@ -1,3 +1,9 @@
 {
-    "quickfix": "targeted" 
+    "quickfix": "targeted" ,
+    "tags": [
+        "cwe",
+        "suspicious",
+        "redundant",
+        "symbolic-execution"
+      ]
 }
diff --git a/rules/S3329/csharp/metadata.json b/rules/S3329/csharp/metadata.json
@@ -1,3 +1,7 @@
 {
-  "quickfix": "targeted"
+  "quickfix": "targeted",
+  "tags": [
+      "cwe",
+      "symbolic-execution"
+    ]
 }
diff --git a/rules/S3329/vbnet/metadata.json b/rules/S3329/vbnet/metadata.json
@@ -1,3 +1,7 @@
 {
-  "quickfix": "targeted"
+  "quickfix": "targeted",
+  "tags": [
+      "cwe",
+      "symbolic-execution"
+    ]
 }
diff --git a/rules/S3655/java/metadata.json b/rules/S3655/java/metadata.json
@@ -1,7 +1,3 @@
 {
-  "title": "Optional value should only be accessed after calling isPresent()",
-  "tags": [
-  	"cwe",
-    "symbolic-execution"
-  ]
+  "title": "Optional value should only be accessed after calling isPresent()"
 }
diff --git a/rules/S3655/metadata.json b/rules/S3655/metadata.json
@@ -13,7 +13,8 @@
     "constantCost": "10min"
   },
   "tags": [
-    "cwe"
+    "cwe",
+    "symbolic-execution"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S3900/metadata.json b/rules/S3900/metadata.json
@@ -13,7 +13,8 @@
     "constantCost": "5min"
   },
   "tags": [
-    "convention"
+    "convention",
+    "symbolic-execution"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S3949/metadata.json b/rules/S3949/metadata.json
@@ -13,7 +13,8 @@
     "constantCost": "5min"
   },
   "tags": [
-    "overflow"
+    "overflow",
+    "symbolic-execution"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S3966/metadata.json b/rules/S3966/metadata.json
@@ -14,7 +14,8 @@
   },
   "tags": [
     "confusing",
-    "pitfall"
+    "pitfall",
+    "symbolic-execution"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S4158/csharp/metadata.json b/rules/S4158/csharp/metadata.json
@@ -1,3 +1,6 @@
 {
-    "quickfix": "infeasible"
+    "quickfix": "infeasible",
+    "tags": [
+        "symbolic-execution"
+        ]
 }
diff --git a/rules/S4158/vbnet/metadata.json b/rules/S4158/vbnet/metadata.json
@@ -1,3 +1,6 @@
 {
-    "quickfix": "infeasible"
+    "quickfix": "infeasible",
+    "tags": [
+        "symbolic-execution"
+    ]
 }
diff --git a/rules/S4347/csharp/metadata.json b/rules/S4347/csharp/metadata.json
@@ -1,2 +1,8 @@
 {
+    "tags":[
+        "cwe",
+        "cert",
+        "pitfall",    
+        "symbolic-execution"
+    ]
 }
diff --git a/rules/S5773/metadata.json b/rules/S5773/metadata.json
@@ -14,7 +14,8 @@
     "constantCost": "30min"
   },
   "tags": [
-    "cwe"
+    "cwe",
+    "symbolic-execution"
   ],
   "extra": {
     "replacementRules": [

diff --git a/rules/S6781/csharp/metadata.json b/rules/S6781/csharp/metadata.json
@@ -1,2 +1,7 @@
 {
+    "tags": [
+        "cwe",
+        "cert",
+        "symbolic-execution"
+    ]
 }
diff --git a/rules/S7130/metadata.json b/rules/S7130/metadata.json
@@ -7,6 +7,7 @@
     "constantCost": "1min"
   },
   "tags": [
+    "symbolic-execution"
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-7130",

diff --git a/rules/S7131/metadata.json b/rules/S7131/metadata.json
@@ -7,6 +7,7 @@
     "constantCost": "30min"
   },
   "tags": [
+    "symbolic-execution"
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-7131",

diff --git a/rules/S7133/metadata.json b/rules/S7133/metadata.json
@@ -7,6 +7,7 @@
     "constantCost": "5min"
   },
   "tags": [
+    "symbolic-execution"
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-7133",