Update S6678: Add VB.NET RSPEC #3919
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/RSPEC-S6678-add-VBNET
branch
from
f7a07c4 to
3191735
Compare
|
|
|
I don't remember why this one was stopped, is there a VB implementation for S6678? If not I guess we can just close the PR |
|
The last one is from @gregory-paidis-sonarsource so he might have more context than me, he's sick at the moment, so let's wait for him to come back before acting on that PR |
|
When we implemented a rule for c# and not for VB.NET, we left the PR open until the rule was implemented for vb.net. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review
A dedicated reviewer checked the rule description successfully for: