Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S7187: PySpark Pandas DataFrame columns should not use a reserved name #4622

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@joke1196 joke1196 changed the title Create rule S7187 Create rule S7187: PySpark Pandas DataFrame columns should not use a reserved name Jan 28, 2025
@joke1196 joke1196 force-pushed the rule/add-RSPEC-S7187 branch from 04c9859 to 8c766ae Compare January 28, 2025 15:54
@joke1196 joke1196 force-pushed the rule/add-RSPEC-S7187 branch from 8c766ae to 82ff822 Compare January 30, 2025 13:12
@joke1196 joke1196 force-pushed the rule/add-RSPEC-S7187 branch from 82ff822 to 55266d9 Compare January 30, 2025 13:20
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clean and concise!
Also I think it's good that you detailed quite a few use cases in the HOW of the ticket (even though I suspect we'll have to accept a few FNs here - it's great to have the target reference)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants