Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S7197: Circular file imports should be resolved #4645

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 31, 2025

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@github-actions github-actions bot added the jsts label Jan 31, 2025
@kaufco kaufco changed the title Create rule S7197 Create rule S7197: Circular file imports should be resolved Jan 31, 2025
@zglicz zglicz marked this pull request as ready for review February 3, 2025 12:48
@zglicz zglicz requested a review from a team February 3, 2025 12:48
@zglicz
Copy link
Contributor

zglicz commented Feb 3, 2025

@gabriel-vivas-sonarsource - rspec PR if you would like to review

Copy link
Contributor

@gabriel-vivas-sonarsource gabriel-vivas-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good. Added a few suggestions, feel free to use what makes sense to you.

rules/S7197/javascript/rule.adoc Outdated Show resolved Hide resolved
rules/S7197/javascript/rule.adoc Show resolved Hide resolved
Copy link

sonarqube-next bot commented Feb 6, 2025

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Feb 6, 2025

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@zglicz zglicz merged commit 1f6167e into master Feb 6, 2025
9 of 10 checks passed
@zglicz zglicz deleted the rule/add-RSPEC-S7197 branch February 6, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants