SONARHTML-276 Remove dev from owners #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/plugins/html/node/
chrislain-razafimahefa-sonarsource
approved these changes
Dec 23, 2024
| * SonarSource :: HTML :: ITs :: Plugin | ||
| * Copyright (c) 2011-2024 SonarSource SA and Matthijs Galesloot | ||
| * [email protected] | ||
| * SonarQube HTML |
There was a problem hiding this comment.
Why is the name 'SonarQube' and not 'SonarSource' ?
There was a problem hiding this comment.
I aligned to what is done in sonar-java: https://github.com/SonarSource/sonar-java/blob/master/sonar-java-plugin/src/main/java/org/sonar/plugins/java/JavaPlugin.java
| @@ -1,19 +1,18 @@ | |||
| /* | |||
| * SonarSource :: HTML :: ITs :: Plugin | |||
| * Copyright (c) 2011-2024 SonarSource SA and Matthijs Galesloot | |||
There was a problem hiding this comment.
Is it ok to remove the guy's name from the license if he was there before?
There was a problem hiding this comment.
We had a long discussion by email and slack with Nico Peru about it. We got his approval and this PR is the execution.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARHTML-276
The logical changes are in the
pom.xmlfiles.The license setup is still flacky, but is out of scope for now: SONARHTML-260