Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONARHTML-287 Fix typo #351

Merged
merged 2 commits into from
Jan 21, 2025
Merged

SONARHTML-287 Fix typo #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77dedc2
Fixing typo in the word defining
dehrk Nov 4, 2024
6ba9851
Updating test to corrected spelling
dehrk Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ugin/src/main/java/org/sonar/plugins/html/checks/accessibility/NoRedundantRolesCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public void startElement(TagNode element) {
}
createViolation(element,
String.format(
"The element %s has an implicit role of %s. Definig this explicitly is redundant and should be avoided.",
"The element %s has an implicit role of %s. Defining this explicitly is redundant and should be avoided.",
element.getNodeName(), implicitRole));
}
}
Expand Down
6 changes: 3 additions & 3 deletions .../src/test/java/org/sonar/plugins/html/checks/accessibility/NoRedundantRolesCheckTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ void html() {
checkMessagesVerifier.verify(sourceCode.getIssues())
.next().atLine(1)
.withMessage(
"The element button has an implicit role of button. Definig this explicitly is redundant and should be avoided.")
"The element button has an implicit role of button. Defining this explicitly is redundant and should be avoided.")
.next().atLine(2)
.noMore();
}
Expand All @@ -50,7 +50,7 @@ void html_with_custom_property() {
new File("src/test/resources/checks/NoRedundantRolesCheck.html"),
check);
checkMessagesVerifier.verify(sourceCode.getIssues())
.next().atLine(6).withMessage("The element nav has an implicit role of navigation. Definig this explicitly is redundant and should be avoided.")
.next().atLine(6).withMessage("The element nav has an implicit role of navigation. Defining this explicitly is redundant and should be avoided.")
.noMore();
}

Expand All @@ -64,7 +64,7 @@ void html_with_invalid_custom_property() {
check);
checkMessagesVerifier.verify(sourceCode.getIssues())
.next().atLine(2)
.next().atLine(6).withMessage("The element nav has an implicit role of navigation. Definig this explicitly is redundant and should be avoided.")
.next().atLine(6).withMessage("The element nav has an implicit role of navigation. Defining this explicitly is redundant and should be avoided.")
.noMore();
}
}
Loading