SONARJAVA-3920 Add quick fixes for S5810 (JUnit5SilentlyIgnoreClassAndMethodCheck) #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardo-pilastri-sonarsource
requested changes
Jan 26, 2023
| @@ -31,9 +32,10 @@ class JUnit5SilentlyIgnoreClassAndMethodCheckTest { | |||
|
|
|||
| @Test | |||
| void test() { | |||
| CheckVerifier.newVerifier() | |||
| InternalCheckVerifier.newInstance() | |||
There was a problem hiding this comment.
Maybe is it a good idea now to also change the other tests to use the InternalCheckVerifier and remove the import of the old CheckVerifier, just to have more consistency
...cks/src/main/java/org/sonar/java/checks/tests/AbstractJUnit5NotCompliantModifierChecker.java
Outdated
Show resolved
Hide resolved
...hecks/src/main/java/org/sonar/java/checks/tests/JUnit5SilentlyIgnoreClassAndMethodCheck.java
Outdated
Show resolved
Hide resolved
Co-authored-by: leonardo-pilastri-sonarsource <[email protected]>
Co-authored-by: leonardo-pilastri-sonarsource <[email protected]>
chrislain-razafimahefa-sonarsource
force-pushed
the
cr/SONARJAVA-3920
branch
from
ad592be to
033d4eb
Compare
|
SonarQube Quality Gate
|
leonardo-pilastri-sonarsource
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.