SONARKT-429 Fix UTs on Windows with autocrlf true #522
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonioaversa
force-pushed
the
antonio/SONARKT-429-fix-uts-on-windows-with-autocrlf-true
branch
from
8b2a050 to
08c3afc
Compare
leveretka
reviewed
Jan 27, 2025
| @@ -38,7 +39,11 @@ internal class KotlinRulesDefinitionTest { | |||
| .isEqualTo("Identical expressions should not be used on both sides of a binary operator") | |||
| Assertions.assertThat(rule.type()).isEqualTo(RuleType.BUG) | |||
| Assertions.assertThat(rule.scope()).isEqualTo(RuleScope.ALL) | |||
| Assertions.assertThat(rule.htmlDescription()).startsWith("<h2>Why is this an issue?</h2>\n<p>Using the same value on both sides") | |||
| val htmlDescription = rule.htmlDescription()?.lines(); | |||
There was a problem hiding this comment.
I think it is safe to use !! here and get rid of nullability. As we don't expect description to be null and if it is it wili fail accordingly
There was a problem hiding this comment.
Indeed, I have also removed the unnecessary ;.
leveretka
approved these changes
Jan 27, 2025
|
|
@leveretka I have addressed the comment. |
leveretka
deleted the
antonio/SONARKT-429-fix-uts-on-windows-with-autocrlf-true
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.