SCAN4NET-222 Refactor RoslynAnalyzerProvider FetchAnalyzerPlugins #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
alex-meseldzija-sonarsource
force-pushed
the
alex/refactor-code
branch
from
d74eb10 to
eb901a0
Compare
pavel-mikula-sonarsource
requested changes
Jan 30, 2025
src/SonarScanner.MSBuild.PreProcessor/Roslyn/RoslynAnalyzerProvider.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/Roslyn/PluginTests.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.PreProcessor.Test/Roslyn/PluginTests.cs
Outdated
Show resolved
Hide resolved
alex-meseldzija-sonarsource
force-pushed
the
alex/refactor-fetch-analyzer-plugin
branch
3 times, most recently
from
5e1962f to
d09d656
Compare
pavel-mikula-sonarsource
approved these changes
Jan 31, 2025
| act = () => new Plugin("key", "version", "\r\n "); | ||
| act.Should().ThrowExactly<ArgumentNullException>().And.ParamName.Should().Be("staticResourceName"); | ||
| var plugin = new Plugin(); | ||
| plugin.AddProperty("pluginKey", "someKey"); |
There was a problem hiding this comment.
Separate scaffolding from assertions to follow our usual test shape. Write 4x AddProperty and then 3x Should()
The last AddProperty should be the ("someOtherProperty", "someOtherValue") as before, to prove that it's a NO-OP
alex-meseldzija-sonarsource
force-pushed
the
alex/refactor-code
branch
from
eb901a0 to
81d2a21
Compare
alex-meseldzija-sonarsource
force-pushed
the
alex/refactor-fetch-analyzer-plugin
branch
2 times, most recently
from
5fb0eda to
1e11364
Compare
alex-meseldzija-sonarsource
force-pushed
the
alex/refactor-fetch-analyzer-plugin
branch
from
1e11364 to
f4efaca
Compare
|
alex-meseldzija-sonarsource
deleted the
alex/refactor-fetch-analyzer-plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCAN4NET-222
Part of SCAN4NET-171
This PR is based on top of #2300