SLVS-1600 Fix single quotation marks not formatted correctly in diff view of rule help description #5949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to prevent html escape characters (e.g. ') which end up in different sup-pieces to be split into different spans (because they won't be rendered correctly in the UI)
…orrectly in the rule help description. This was causes by the fact that the single quotation mark was both html encoded and escaped by the XmlWriter. Which means that when & from the html escape character ' was escaped by the XmlWriter, it ended up to be amp;#39;, which couldn't be interpreted as the single quote character
…ol on the received html content and for better testability (e.g. html encoding and XML writer encoding sometimes lead to invalid characters, when XmlWriter encodes special characters from html escape characters)
gabriela-trutan-sonarsource
requested review from
georgii-borovinskikh-sonarsource
and removed request for
georgii-borovinskikh-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVS-1600