Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVS-1786 Promote t-sql to standalone users #5972

Merged
merged 2 commits into from
Jan 30, 2025
Merged

SLVS-1786 Promote t-sql to standalone users #5972

merged 2 commits into from
Jan 30, 2025

Conversation

vnaskos-sonar
Copy link
Contributor

@vnaskos-sonar vnaskos-sonar commented Jan 29, 2025 •
edited by jira bot
Loading

georgii-borovinskikh-sonarsource
georgii-borovinskikh-sonarsource approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small issues, don't need to re-review when you fix them

src/SLCore.Listeners/Implementation/PromoteListener.cs Outdated Show resolved Hide resolved
src/SLCore.Listeners/Implementation/PromoteListener.cs Outdated Show resolved Hide resolved
src/ConnectedMode/Promote/PromoteGoldBar.cs Outdated Show resolved Hide resolved
src/ConnectedMode/Promote/PromoteGoldBar.cs Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource merged commit 3fcc64e into feature/hardening-1-q1 Jan 30, 2025
3 checks passed
@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource deleted the vn/promote-tsql branch January 30, 2025 16:22
georgii-borovinskikh-sonarsource pushed a commit that referenced this pull request Jan 31, 2025
@vnaskos-sonar @georgii-borovinskikh-sonarsource
SLVS-1786 Promote t-sql to standalone users (#5972)
1d85f9c 
[SLVS-1786](https://sonarsource.atlassian.net/browse/SLVS-1786)

[SLVS-1786]:
https://sonarsource.atlassian.net/browse/SLVS-1786?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
vnaskos-sonar added a commit that referenced this pull request Jan 31, 2025
@vnaskos-sonar
SLVS-1786 Promote t-sql to standalone users (#5972)
c79c84a 
[SLVS-1786](https://sonarsource.atlassian.net/browse/SLVS-1786)

[SLVS-1786]:
https://sonarsource.atlassian.net/browse/SLVS-1786?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnaskos-sonar @georgii-borovinskikh-sonarsource