SLVS-1853 Refactor the RoslynSettingsFileSynchronizer to not use ServerIssueStore

src/ConnectedMode/Suppressions/ISuppressionUpdater.cs

@@ -25,7 +25,7 @@ namespace SonarLint.VisualStudio.ConnectedMode.Suppressions;
 /// <summary>
 /// Fetches suppressed issues from the server and raises events. This is mainly needed for Roslyn languages
 /// </summary>
-internal interface ISuppressionUpdater
+public interface ISuppressionUpdater
 {
     /// <summary>
     /// Fetches all available suppressions from the server and raises the <see cref="SuppressedIssuesReloaded"/> event.

src/Integration.Vsix/SonarLintIntegrationPackage.cs

@@ -22,7 +22,6 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Runtime.InteropServices;
 using Microsoft.VisualStudio.Shell;
-using Microsoft.VisualStudio.Threading;
 using SonarLint.VisualStudio.ConnectedMode.UI;
 using SonarLint.VisualStudio.Core;
 using SonarLint.VisualStudio.Infrastructure.VS;
@@ -85,9 +84,9 @@ private async Task InitOnUIThreadAsync()
 
                 IServiceProvider serviceProvider = this;
 
-                this.commandManager = new PackageCommandManager(serviceProvider.GetService<IMenuCommandService>());
+                commandManager = new PackageCommandManager(serviceProvider.GetService<IMenuCommandService>());
 
-                this.commandManager.Initialize(
+                commandManager.Initialize(
                     serviceProvider.GetMefService<IProjectPropertyManager>(),
                     serviceProvider.GetMefService<IOutputWindowService>(),
                     serviceProvider.GetMefService<IShowInBrowserService>(),
@@ -96,8 +95,8 @@ private async Task InitOnUIThreadAsync()
                     serviceProvider.GetMefService<IConnectedModeBindingServices>(),
                     serviceProvider.GetMefService<IConnectedModeUIManager>());
 
-                this.roslynSettingsFileSynchronizer = await this.GetMefServiceAsync<IRoslynSettingsFileSynchronizer>();
-                roslynSettingsFileSynchronizer.UpdateFileStorageAsync().Forget(); // don't wait for it to finish
+                // make sure roslynSettingsFileSynchronizer is initialized
+                roslynSettingsFileSynchronizer = await this.GetMefServiceAsync<IRoslynSettingsFileSynchronizer>();
                 Debug.Assert(threadHandling.CheckAccess(), "Still expecting to be on the UI thread");
 
                 logger.WriteLine(Strings.SL_InitializationComplete);
@@ -114,8 +113,8 @@ protected override void Dispose(bool disposing)
             base.Dispose(disposing);
             if (disposing)
             {
-                this.roslynSettingsFileSynchronizer?.Dispose();
-                this.roslynSettingsFileSynchronizer = null;
+                roslynSettingsFileSynchronizer?.Dispose();
+                roslynSettingsFileSynchronizer = null;
             }
         }
     }

src/Roslyn.Suppressions/Roslyn.Suppressions.UnitTests/InProcess/IssueConverterTests.cs

@@ -18,8 +18,6 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
-using FluentAssertions;
-using Microsoft.VisualStudio.TestTools.UnitTesting;
 using SonarLint.VisualStudio.Roslyn.Suppressions.InProcess;
 using static SonarLint.VisualStudio.Roslyn.Suppressions.UnitTests.TestHelper;
 
@@ -31,12 +29,13 @@ public class IssueConverterTests
         [TestMethod]
         public void Convert_SimplePropertiesAreHandledCorrectly()
         {
-            var sonarIssue = CreateSonarQubeIssue(hash: "aaaa", filePath: "\\bbb\\ccc\\file.txt");
+            var sonarIssue = CreateSonarQubeIssue(hash: "aaaa", filePath: "\\bbb\\ccc\\file.txt", issueKey: "key");
 
-            var actual = RoslynSettingsFileSynchronizer.IssueConverter.Convert(sonarIssue);
+            var actual = IssueConverter.Convert(sonarIssue);
 
             actual.Hash.Should().Be("aaaa");
             actual.FilePath.Should().Be("\\bbb\\ccc\\file.txt");
+            actual.IssueServerKey.Should().Be("key");
         }
 
         [TestMethod]
@@ -48,9 +47,9 @@ public void Convert_LineNumbersAreHandledCorrectly(int? sonarLineNumber, int? ex
             // 1-based Sonar line numbers should be converted to 0-based Roslyn line numbers
             var sonarIssue = CreateSonarQubeIssue(line: sonarLineNumber);
 
-            var actual = RoslynSettingsFileSynchronizer.IssueConverter.Convert(sonarIssue);
+            var actual = IssueConverter.Convert(sonarIssue);
 
-            if(expected.HasValue)
+            if (expected.HasValue)
             {
                 actual.RoslynIssueLine.Value.Should().Be(expected);
             }
@@ -80,7 +79,7 @@ public void Convert_RepoKeysAreHandledCorrectly(string compositeKey, RoslynLangu
         {
             var sonarIssue = CreateSonarQubeIssue(ruleId: compositeKey);
 
-            var actual = RoslynSettingsFileSynchronizer.IssueConverter.Convert(sonarIssue);
+            var actual = IssueConverter.Convert(sonarIssue);
 
             actual.RoslynLanguage.Should().Be(expectedLanguage);
             actual.RoslynRuleId.Should().Be(expectedRuleKey);