Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLVS-1753 SLVS-1754 Send mute issue request to SlCore #6030

Merged
merged 23 commits into from
Feb 18, 2025
Merged

SLVS-1753 SLVS-1754 Send mute issue request to SlCore #6030

merged 23 commits into from
Feb 18, 2025

Conversation

vnaskos-sonar
Copy link
Contributor

@vnaskos-sonar vnaskos-sonar commented Feb 14, 2025 •
edited by jira bot
Loading

@vnaskos-sonar vnaskos-sonar changed the title SLVS-1753 Send mute issue request to SlCore SLVS-1753 SLVS-1754 Send mute issue request to SlCore Feb 14, 2025
@vnaskos-sonar vnaskos-sonar marked this pull request as ready for review February 14, 2025 15:17
gabriela-trutan-sonarsource
gabriela-trutan-sonarsource requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality seems to work, but I have some feedback

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource mentioned this pull request Feb 17, 2025
Merged
@vnaskos-sonar
Remove the ServerIssuesStoreWriter from MuteIssuesService
189f4f5
@vnaskos-sonar
Remove the SonarQubeService from MuteIssuesService
2c88754
@vnaskos-sonar
Change ResolveIssueWithDialogAsync method signature
df520c8
@vnaskos-sonar
Mute issue using the SlCore service
7fd1c02
@vnaskos-sonar
Call SLCore CheckStatusChangePermittedAsync
47a1b90
@vnaskos-sonar
Cleanup string resources
e4f2ba9
@vnaskos-sonar
Cleanup obsolete tests
119a60a
@vnaskos-sonar
Add test for null config scope
7fab227
@vnaskos-sonar
Move TryGetTransientService inside try catch
eb66b6a
@vnaskos-sonar
Add more tests
3cf1707
@vnaskos-sonar
Trim empty comment
3369f7c
@vnaskos-sonar
Add context logger
a89ba9d
@vnaskos-sonar
Catch and return false on CancelledException
cf26bfb
@vnaskos-sonar
Replace concrete exception types with generic and test for logs
f483efa
@vnaskos-sonar
Test logger for correct context
5440562
@vnaskos-sonar
Check for empty issue server key
23f9c9f
@vnaskos-sonar
Change IssueNotFound message
ca3cbcd
@vnaskos-sonar
CaYC: Replace Mock with NSubstitute
2b86418
@vnaskos-sonar
Add test cases for MuteIssueException behavior
a43379e
@vnaskos-sonar
Show message when mute succeeded but comment failed
0751b1c
@vnaskos-sonar
Show message if roslyn issue is already resolved on server
4d0b6af
gabriela-trutan-sonarsource
gabriela-trutan-sonarsource approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok now. I just had some minor findings.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vnaskos-sonar vnaskos-sonar merged commit b19afa8 into feature/sloop-mute-issue Feb 18, 2025
3 checks passed
@vnaskos-sonar vnaskos-sonar deleted the vn/mute-issue-command branch February 18, 2025 07:35
gabriela-trutan-sonarsource pushed a commit that referenced this pull request Mar 4, 2025
@vnaskos-sonar @gabriela-trutan-sonarsource
SLVS-1753 SLVS-1754 Send mute issue request to SlCore (#6030)
b5bc57d
gabriela-trutan-sonarsource pushed a commit that referenced this pull request Mar 4, 2025
@vnaskos-sonar @gabriela-trutan-sonarsource
SLVS-1753 SLVS-1754 Send mute issue request to SlCore (#6030)
be78b3b
gabriela-trutan-sonarsource pushed a commit that referenced this pull request Mar 4, 2025
@vnaskos-sonar @gabriela-trutan-sonarsource
SLVS-1753 SLVS-1754 Send mute issue request to SlCore (#6030)
45e7b8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriela-trutan-sonarsource gabriela-trutan-sonarsource gabriela-trutan-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnaskos-sonar @gabriela-trutan-sonarsource