Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Now Playing notification #376

Closed
wants to merge 2 commits into from

Conversation

kuroidoruido
Copy link

Ask by @manichardtiger with issue #370.

When a music start playing, a notification will pop. This notification includes song title, play time, artist and album.

Tested on ArchLinux/Gnome 3.34.0 with Firefox 69 and Chromium 77.

@kuroidoruido
Copy link
Author

I forgot a notification screenshot example (Archlinux + Gnome 3 + Firefox)
PR_firefox_notif

@manichardtiger
Copy link

@kuroidoruido thanks for the effort!

Should this also work on Windows? I tried with Windows 10, Chrome & Firefox but with no success

Thanks

@kuroidoruido
Copy link
Author

@manichardtiger I use only standard notification API so it should work.

Fail to send notification is silent currently (Notification object not present, authorization rejected, ...), so maybe you rejected notifications ?

I will make a try on windows by myself soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants