Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnessary code #292

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

blacklee123
Copy link
Contributor

Whether this PR is eventually merged or not, Sonic will thank you very much for your contribution.

无论此PR最终是否合并,Sonic组织都非常感谢您的贡献。

Checklist

  • The title starts with fix, fea, or doc. | 标题为fix、feat或doc开头。
  • I have checked that there are no duplicate pull requests with this request. | 我已检查没有与此请求重复的拉取请求。
  • I have considered and confirmed that this submission is valuable to others. | 我已经考虑过,并确认这份呈件对其他人很有价值。
  • I accept that this submission may not be used. | 我接受此提交可能不会被使用。

Description

这里的代码没有必要,删除后可以简化一下逻辑,同时sonic-server的docker-compose.yml也不需要再设置对应的环境变量

Copy link
Member

@ZhouYixun ZhouYixun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实,以前前后端不同域,现在合并了前面域,理论上只给相对path就可以了

你已经经过了测试了吗?

@blacklee123
Copy link
Contributor Author

确实,以前前后端不同域,现在合并了前面域,理论上只给相对path就可以了

你已经经过了测试了吗?

经过了测试,没有发现问题

@ZhouYixun ZhouYixun merged commit f278bc6 into SonicCloudOrg:main Aug 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants