[#35] 질문 조회 페이지 #39
Merged
[#35] 질문 조회 페이지 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seocylucky
reviewed
Aug 21, 2023
pages/questionRead/[pid].tsx
Outdated
|
|
||
| const Container = styled.section` | ||
| width: 100%; | ||
| height: 100vh; |
There was a problem hiding this comment.
요고 height: auto 로 하는거 어떨까요? 푸터를 넣었을 때 auto로 해야 푸터가 맨 밑에 하단으로 가더라구요!!
seocylucky
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
질문 조회 페이지 제작
Description
이슈 넘버: [#35] 질문 조회 페이지 #35
피그마:
관련 문서:
Details
Routing
[pid].tsx라는 파일을 만들어서 동적 라우팅이 가능하게 하였습니다.Search
Search컴포넌트의 props로variant옵션을up|down으로 받아서 열리는 방향을 선택 가능하게끔 하였습니다. (홈화면은 위로 열림)Question
Tag컴포넌트 사용하여서 UI 맞추어 제작MyAnswer
Key Changes
true로 설정하여서 기존의 컴포넌트들이 수정할 필요는 없게 하였습니다.To Reviewer
After Work
Tag컴포넌트 overflow 고려 (기획 / 디자이너님과 논의)