Added the ability for recursive snapshots #1
Conversation
This way we can have multiple subsets of snapshots (e.g. hourly, daily, weekly, etc.).
zfs-snapshotter.bash
Outdated
| # Snapshot to take: | ||
| SNAP="${DATASET}@$(date "+%Y-%m-%d")${SUFFIX}" | ||
| # We dive through all the datasets and just hit those without $AUTOSNAP = false | ||
| for DS in `zfs list $DATASET $RECURSIV -H | awk '{ print $1}'`; do |
There was a problem hiding this comment.
I think this could be simplified with zfs list $DATASET $RECURSIV -H -o name, so awk isn't needed anymore (and we could avoid messing with PATH)
There was a problem hiding this comment.
Well... Right. :) I'll change it. In an additional change I added respecting com.sun:auto-snapshot for recursive snapshots. There I used awk too. But there I could also change it.
I'll do it and give a new pull-request (I have no experiance with pull-requests...)
zfs-snapshotter.bash
Outdated
| @@ -1,9 +1,12 @@ | |||
| #! /usr/bin/env bash | |||
|
|
|||
| PATH=$PATH:/sbin | |||
There was a problem hiding this comment.
Is this because of awk? If so it can probably be removed from line 42 (see my other comment)
There was a problem hiding this comment.
No, this was because of debugging I did on my debian machine (having zfs not in PATH). I removed it in a later commit.
|
Made a new pull request |
With the
-roption recursive snapshots can be taken. If used with-rthe script respects com.sun:auto-snapshot