Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file deletion options for rotated files #71

Merged
merged 1 commit into from
May 2, 2024

Conversation

lomby92
Copy link
Contributor

@lomby92 lomby92 commented Apr 23, 2024

Closes #70

@Bungeefan Bungeefan self-requested a review April 23, 2024 20:37
@lomby92
Copy link
Contributor Author

lomby92 commented May 2, 2024

If you need any explanation on the implementation, feel free to reach me out

@Bungeefan
Copy link
Member

Hi, thanks for the offer! Sorry for the delay in reviewing, I had a quite busy week, will do it ASAP.

@Bungeefan Bungeefan merged commit e55c71c into SourceHorizon:main May 2, 2024
2 checks passed
@Bungeefan
Copy link
Member

Your tests seem to be kind of flaky, especially on GitHub Actions 🤔

@Bungeefan
Copy link
Member

That's quite interesting.
After some tests on my part, I found that the only test that is flaky on my machine is the "custom file sorter" (fixable with a small timeout, probably because of file system flush) but for GitHub Actions it seems like it's only struggling with the regular "files deletion" one.
I can't really reproduce this on my side yet...

@lomby92
Copy link
Contributor Author

lomby92 commented May 3, 2024

Really interesting since i didn't encountered problems during development.

OS: Fedora Linux
Kernel: 6.8.7-100
Flutter: 3.19.5
Dart: 3.3.3

@Bungeefan
Copy link
Member

After some tests with my private Jenkins (where I could reproduce the GitHub Actions failures), I found out that 1000ms seem to be minimal sleep duration that doesn't trigger any flakiness in the test.

I still want to find out why there is such a flakiness even with some sleep steps in the test, however, as this doesn't seem to be a problem in your code and shouldn't impact any users, I will no longer delay the release of 2.3.0.

logger v2.3.0 has been successfully published on pub.dev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to limit the number of files created by AdvancedFileOutput
2 participants