Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaBatch and ChangeSet changes immutable sov_state::Storage migration #5

Merged
merged 5 commits into from
May 14, 2024

Conversation

citizen-stig
Copy link
Member

@citizen-stig citizen-stig commented May 6, 2024

While migrating to simplified ProverStorageManager SDK needs to have workaround to build change set with particular ID from 2 SchemaBatches. This PR solves this.

Another change is adding SchemaBatch::get_value function. This allows ProverStorage to use data previously materialized to be read immediately.

src/lib.rs Outdated Show resolved Hide resolved
@citizen-stig citizen-stig changed the title Temporary constructor for the ChangeSet while migration SchemaBatch and ChangeSet changes immutable sov_state::Storage migration May 13, 2024
@citizen-stig citizen-stig marked this pull request as ready for review May 13, 2024 15:47
@citizen-stig citizen-stig requested a review from neysofu May 13, 2024 15:47
Copy link
Member

@neysofu neysofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@citizen-stig citizen-stig merged commit 11c7f74 into main May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants