-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel Scout support #4032
Laravel Scout support #4032
Conversation
*/ | ||
protected function chunk($query) | ||
{ | ||
if ($query instanceof \Laravel\Scout\Builder) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cellard this breaks for everyone not using Laravel scout but do use laravel Excel :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't break anything for me. I'm not using Laravel Scout, everything still works like expected. instanceof
checks can run on non-existing classes.
This reverts commit 6d3c78c.
This PR brings support of
Laravel\Scout\Builder
toFromQuery
concern.Users not infrequently want to export their search results. Laravel Scout is a good instrument for searching.
I write tests — for queued and direct writer.