Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Driver Pattern Documentation #2739

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thatstatsguy
Copy link

As I was reading through the Driver Pattern documentation, I realized that it could be improved to drive home the potential benefits of using the approach.

Types of changes

I've rejigged the introduction to the article.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Performance improvement
  • Refactoring (so no functional change)
  • Other (docs, build config, etc)

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@thatstatsguy thatstatsguy changed the title Thatstatsguy patch 1 Improve Driver Pattern Documentation Feb 8, 2024
@thatstatsguy
Copy link
Author

not entirely sure why the one check wasn't successful - if anyone know where to check logs that would be appreciated!

@thatstatsguy
Copy link
Author

@SabotageAndi any chance you might know who is best to get this reviewed?

Also noticing other PRs with the same issue as what I've mentioned above

@SabotageAndi
Copy link
Contributor

@thatstatsguy Sadly I can't help you.
I don't know anybody at Tricentis that is working on SpecFlow anymore.

You have probably more luck in switching to Reqnroll (https://github.com/reqnroll/Reqnroll/) and send the PR there.

@thatstatsguy
Copy link
Author

appreciate the response @SabotageAndi ! pity that the repo isn't getting much attention

@304NotModified
Copy link
Contributor

FYI #2719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants