Updates to New User Monitor task project #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The original project was written like a management driver, but it is more useful as a triggered task. I removed the driver files and procs, and some customer information. Also removed hard coded IPs, usernames and passwords, and parameters.
Types of Changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask @kalina-k. We're here to help! This is simply a reminder of what we are going to look for before merging your code.[] Project name conforms to the naming convention described here
[] Project name is unique within the repository
[] Project exists in the appropriate directory based on its category and class, e.g. Drivers/Community
[] Project contains a file called documentation/readme.txt with metadata necessary for the catalog. The readme.txt file must contain these 4 lines at the top of the file:
Project: Name of project.
Description: 80 or so characters describing the contents of the project
Category: ("driver" | "task" | "dashboard")
Class: ("Community" | "Tested by Spirent" | "Reference")
Other info like user instructions, a description of the intended use case, etc. can be added to the readme.txt after the 4 required lines.
Note: A README.md file will be automatically generated including everything in the readme.txt file and a list of files, QuickCalls, and procedures with info from iTest's documentation fields. Do not create a README.md file, it will be overwritten. For the best possible documentation, fill out the description fields in each test case, procedure and QuickCall.