Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/api-12' into api-13
Browse files Browse the repository at this point in the history
  • Loading branch information
aromaa committed Jan 29, 2025
2 parents d8af4d8 + 06a58ae commit f913752
Show file tree
Hide file tree
Showing 15 changed files with 241 additions and 186 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import net.minecraft.server.level.ServerLevel;
import net.minecraft.world.ticks.ScheduledTick;
import org.spongepowered.api.event.CauseStackManager;
import org.spongepowered.common.bridge.world.ticks.ScheduledTickBridge;
import org.spongepowered.common.event.tracking.PhaseTracker;

import java.util.function.BiConsumer;
Expand Down Expand Up @@ -57,6 +56,5 @@ public BiConsumer<CauseStackManager.StackFrame, ChunkLoadContext> getFrameModifi
public void associateScheduledTickUpdate(
final ChunkLoadContext asContext, ServerLevel level, final ScheduledTick<?> entry
) {
((ScheduledTickBridge) (Object) entry).bridge$setIsPartOfWorldGeneration(true);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,11 @@
package org.spongepowered.common.event.tracking.phase.generation;

import net.minecraft.core.BlockPos;
import net.minecraft.server.level.ServerLevel;
import org.checkerframework.checker.nullness.qual.NonNull;
import org.spongepowered.api.event.CauseStackManager;
import org.spongepowered.common.event.tracking.PhaseTracker;
import org.spongepowered.common.event.tracking.phase.tick.LocationBasedTickContext;

import java.util.Objects;
import java.util.function.BiConsumer;
Expand Down Expand Up @@ -74,5 +77,11 @@ public BlockPos location() {
public Object type() {
return Objects.requireNonNull(this.type, "NextTickListEntry was not initialized");
}

@Override
public void appendNotifierPreBlockTick(final ServerLevel world, final BlockPos pos, final LocationBasedTickContext<@NonNull ?> phaseContext) {
this.applyOwnerIfAvailable(phaseContext::creator);
this.applyNotifierIfAvailable(phaseContext::notifier);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraft.world.level.chunk.LevelChunk;
import net.minecraft.world.level.saveddata.maps.MapItemSavedData;
import net.minecraft.world.ticks.SavedTick;
import net.minecraft.world.ticks.ScheduledTick;
import org.spongepowered.api.data.DataHolder;
import org.spongepowered.api.data.DataManipulator;
import org.spongepowered.api.data.DataProvider;
Expand All @@ -54,7 +56,9 @@
SpongeBlockSnapshot.class,
SimpleNBTDataHolder.class,
MapItemSavedData.class,
LevelChunk.class})
LevelChunk.class,
ScheduledTick.class,
SavedTick.class})
public abstract class SpongeDataHolderMixin implements SpongeDataHolderBridge {

private DataManipulator.Mutable impl$manipulator;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,11 @@
import org.spongepowered.common.entity.player.tab.SpongeTabList;
import org.spongepowered.common.event.ShouldFire;
import org.spongepowered.common.event.SpongeCommonEventFactory;
import org.spongepowered.common.event.tracking.PhaseContext;
import org.spongepowered.common.event.tracking.PhaseTracker;
import org.spongepowered.common.event.tracking.phase.packet.BasicPacketContext;
import org.spongepowered.common.event.tracking.phase.packet.PacketPhase;
import org.spongepowered.common.event.tracking.phase.player.PlayerPhase;
import org.spongepowered.common.item.util.ItemStackUtil;
import org.spongepowered.common.network.channel.SpongeChannelPayload;
import org.spongepowered.common.profile.SpongeGameProfile;
Expand Down Expand Up @@ -442,9 +444,17 @@ public abstract class ServerGamePacketListenerImplMixin extends ServerCommonPack
return; // prevents Mismatch in destroy block pos warning
}
}
playerInteractionManager.handleBlockBreakAction(pos, act, dir, maxBuildHeight, sequence);
if (act == ServerboundPlayerActionPacket.Action.START_DESTROY_BLOCK) {
this.impl$ignorePackets++;
final PhaseTracker tracker = PhaseTracker.getWorldInstance(this.player.serverLevel());
try (final CauseStackManager.StackFrame frame = tracker.pushCauseFrame();
final PhaseContext<?> context = PlayerPhase.State.PLAYER_INTERACT.createPhaseContext(tracker)
.creator(this.player.getUUID())
.notifier(this.player.getUUID())) {
context.buildAndSwitch();
frame.pushCause(event);
playerInteractionManager.handleBlockBreakAction(pos, act, dir, maxBuildHeight, sequence);
if (act == ServerboundPlayerActionPacket.Action.START_DESTROY_BLOCK) {
this.impl$ignorePackets++;
}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
*/
package org.spongepowered.common.mixin.core.server.players;

import com.llamalad7.mixinextras.sugar.Local;
import io.netty.channel.local.LocalAddress;
import net.kyori.adventure.audience.Audience;
import net.kyori.adventure.identity.Identity;
Expand Down Expand Up @@ -54,6 +55,7 @@
import net.minecraft.world.level.Level;
import net.minecraft.world.level.border.BorderChangeListener;
import net.minecraft.world.level.border.WorldBorder;
import net.minecraft.world.level.portal.TeleportTransition;
import net.minecraft.world.level.storage.PlayerDataStorage;
import org.checkerframework.checker.nullness.qual.Nullable;
import org.objectweb.asm.Opcodes;
Expand Down Expand Up @@ -160,8 +162,6 @@ public abstract class PlayerListMixin implements PlayerListBridge {
private boolean impl$isRespawnWithPosition = false;
private boolean impl$isDuringSystemMessageEvent = false;

private ResourceKey<Level> impl$originalRespawnDestination = null;

@Inject(method = "<init>", at = @At("RETURN"))
private void impl$setSpongeLists(final CallbackInfo callbackInfo) {
this.bans = new SpongeUserBanList(PlayerList.USERBANLIST_FILE);
Expand Down Expand Up @@ -501,12 +501,6 @@ public abstract class PlayerListMixin implements PlayerListBridge {
this.impl$isRespawnWithPosition = $$0.getRespawnPosition() != null;
}

@Inject(method = "respawn", at = @At(value = "HEAD"))
private void impl$callRespawnPlayerSelectWorld(final net.minecraft.server.level.ServerPlayer player, final boolean $$1,
final Entity.RemovalReason $$2, final CallbackInfoReturnable<net.minecraft.server.level.ServerPlayer> cir) {
this.impl$originalRespawnDestination = player.getRespawnDimension();
}

@Redirect(
method = "respawn",
at = @At(value = "INVOKE", target = "Lnet/minecraft/server/level/ServerPlayer;getX()D"),
Expand All @@ -516,7 +510,7 @@ public abstract class PlayerListMixin implements PlayerListBridge {
)
)
private double impl$callRespawnPlayerRecreateEvent(final net.minecraft.server.level.ServerPlayer newPlayer,
final net.minecraft.server.level.ServerPlayer player, final boolean keepAllPlayerData) {
final net.minecraft.server.level.ServerPlayer player, final boolean keepAllPlayerData, final @Local TeleportTransition dimensionTransition) {
final ServerPlayer originalPlayer = (ServerPlayer) player;
final ServerPlayer recreatedPlayer = (ServerPlayer) newPlayer;

Expand All @@ -527,7 +521,7 @@ public abstract class PlayerListMixin implements PlayerListBridge {

final RespawnPlayerEvent.Recreate event = SpongeEventFactory.createRespawnPlayerEventRecreate(PhaseTracker.getCauseStackManager().currentCause(),
destinationPosition, originalWorld, originalPosition, destinationWorld,
(ServerWorld) this.server.getLevel(this.impl$originalRespawnDestination),
(ServerWorld) dimensionTransition.newLevel(),
destinationPosition, originalPlayer, recreatedPlayer, this.impl$isRespawnWithPosition, !keepAllPlayerData);
SpongeCommon.post(event);

Expand Down Expand Up @@ -555,15 +549,13 @@ public abstract class PlayerListMixin implements PlayerListBridge {

@Inject(method = "respawn", at = @At("RETURN"))
private void impl$callRespawnPlayerPostEvent(final net.minecraft.server.level.ServerPlayer player, final boolean $$1, final Entity.RemovalReason $$2,
final CallbackInfoReturnable<net.minecraft.server.level.ServerPlayer> cir) {
final CallbackInfoReturnable<net.minecraft.server.level.ServerPlayer> cir, final @Local TeleportTransition dimensionTransition) {
final ServerPlayer recreatedPlayer = (ServerPlayer) cir.getReturnValue();
final ServerWorld originalWorld = (ServerWorld) player.serverLevel();

final RespawnPlayerEvent.Post event = SpongeEventFactory.createRespawnPlayerEventPost(PhaseTracker.getCauseStackManager().currentCause(),
recreatedPlayer.world(), originalWorld, (ServerWorld) this.server.getLevel(this.impl$originalRespawnDestination), recreatedPlayer);
recreatedPlayer.world(), originalWorld, (ServerWorld) dimensionTransition.newLevel(), recreatedPlayer);
SpongeCommon.post(event);

this.impl$originalRespawnDestination = null;
}

@Redirect(method = "sendLevelInfo", at = @At(value = "INVOKE", target = "Lnet/minecraft/server/MinecraftServer;overworld()Lnet/minecraft/server/level/ServerLevel;"))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,26 +26,34 @@

import com.google.common.collect.Iterators;
import com.llamalad7.mixinextras.injector.ModifyExpressionValue;
import com.llamalad7.mixinextras.injector.wrapoperation.Operation;
import com.llamalad7.mixinextras.injector.wrapoperation.WrapOperation;
import net.minecraft.server.level.ServerLevel;
import net.minecraft.world.ticks.LevelChunkTicks;
import net.minecraft.world.ticks.LevelTicks;
import net.minecraft.world.ticks.SavedTick;
import net.minecraft.world.ticks.ScheduledTick;
import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
import org.spongepowered.api.scheduler.ScheduledUpdate;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import org.spongepowered.common.bridge.CreatorTrackedBridge;
import org.spongepowered.common.bridge.data.SpongeDataHolderBridge;
import org.spongepowered.common.bridge.world.ticks.LevelChunkTicksBridge;
import org.spongepowered.common.bridge.world.ticks.LevelTicksBridge;
import org.spongepowered.common.bridge.world.ticks.TickNextTickDataBridge;
import org.spongepowered.common.entity.PlayerTracker;
import org.spongepowered.common.event.tracking.PhaseContext;
import org.spongepowered.common.event.tracking.PhaseTracker;

import java.util.Iterator;

@Mixin(LevelChunkTicks.class)
public abstract class LevelChunkTicksMixin<T> implements LevelChunkTicksBridge<T> {

private LevelTicks<T> impl$tickList;
private @MonotonicNonNull LevelTicks<T> impl$tickList;

@Override
public void bridge$setTickList(final LevelTicks<T> tickList) {
Expand All @@ -56,7 +64,10 @@ public abstract class LevelChunkTicksMixin<T> implements LevelChunkTicksBridge<T
@Inject(method = "scheduleUnchecked", at = @At("HEAD"))
private void impl$onScheduleUnchecked(final ScheduledTick<T> $$0, final CallbackInfo ci) {
final ServerLevel level = ((LevelTicksBridge<?>) this.impl$tickList).bridge$level();
PhaseTracker.getWorldInstance(level).getPhaseContext().associateScheduledTickUpdate(level, $$0);
final PhaseContext<?> context = PhaseTracker.getWorldInstance(level).getPhaseContext();
context.associateScheduledTickUpdate(level, $$0);
context.applyOwnerIfAvailable(owner -> ((CreatorTrackedBridge) (Object) $$0).tracker$setTrackedUUID(PlayerTracker.Type.CREATOR, owner));
context.applyNotifierIfAvailable(notified -> ((CreatorTrackedBridge) (Object) $$0).tracker$setTrackedUUID(PlayerTracker.Type.NOTIFIER, notified));
((TickNextTickDataBridge<T>) (Object) $$0).bridge$createdByList(level, (LevelChunkTicks) (Object) this);
}

Expand All @@ -65,4 +76,11 @@ public abstract class LevelChunkTicksMixin<T> implements LevelChunkTicksBridge<T
private Iterator<ScheduledTick<T>> impl$onSaveSkipCancelled(final Iterator<ScheduledTick<T>> original) {
return Iterators.filter(original, t -> ((TickNextTickDataBridge<T>) (Object) t).bridge$internalState() != ScheduledUpdate.State.CANCELLED);
}

@WrapOperation(method = "unpack", at = @At(value = "INVOKE", target = "Lnet/minecraft/world/ticks/SavedTick;unpack(JJ)Lnet/minecraft/world/ticks/ScheduledTick;"))
private ScheduledTick<T> impl$onUnpackTransferSpongeData(final SavedTick<T> instance, final long $$0, final long $$1, final Operation<ScheduledTick<T>> original) {
final ScheduledTick<T> tick = original.call(instance, $$0, $$1);
((SpongeDataHolderBridge) (Object) tick).bridge$mergeDeserialized(((SpongeDataHolderBridge) (Object) instance).bridge$getManipulator());
return tick;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
/*
* This file is part of Sponge, licensed under the MIT License (MIT).
*
* Copyright (c) SpongePowered <https://www.spongepowered.org>
* Copyright (c) contributors
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
package org.spongepowered.common.mixin.core.world.ticks;

import net.minecraft.nbt.CompoundTag;
import net.minecraft.world.ticks.SavedTick;
import org.checkerframework.checker.nullness.qual.Nullable;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
import org.spongepowered.common.bridge.CreatorTrackedBridge;
import org.spongepowered.common.bridge.data.DataCompoundHolder;
import org.spongepowered.common.data.DataUtil;
import org.spongepowered.common.data.holder.SpongeMutableDataHolder;

import java.util.Optional;
import java.util.function.Function;

@Mixin(SavedTick.class)
public abstract class SavedTickMixin<T> implements SpongeMutableDataHolder, DataCompoundHolder, CreatorTrackedBridge {

private @Nullable CompoundTag impl$compound;

@Override
public CompoundTag data$getCompound() {
return this.impl$compound;
}

@Override
public void data$setCompound(final CompoundTag nbt) {
this.impl$compound = nbt;
}

@Inject(method = "save", at = @At("RETURN"))
private void impl$onSaveTick(final CallbackInfoReturnable<CompoundTag> cir) {
if (DataUtil.syncDataToTag(this)) {
cir.getReturnValue().merge(this.data$getCompound());
}
}

@Inject(method = "loadTick", at = @At("RETURN"))
private static <T> void impl$onLoad(final CompoundTag $$0, final Function<String, Optional<T>> $$1, final CallbackInfoReturnable<Optional<SavedTick<T>>> cir) {
cir.getReturnValue().ifPresent(tick -> {
((DataCompoundHolder) (Object) tick).data$setCompound($$0);
DataUtil.syncTagToData(tick);
((DataCompoundHolder) (Object) tick).data$setCompound(null);
});
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,24 +27,34 @@

import net.kyori.adventure.util.Ticks;
import net.minecraft.core.BlockPos;
import net.minecraft.nbt.CompoundTag;
import net.minecraft.server.level.ServerLevel;
import net.minecraft.world.ticks.LevelChunkTicks;
import net.minecraft.world.ticks.SavedTick;
import net.minecraft.world.ticks.ScheduledTick;
import org.checkerframework.checker.nullness.qual.MonotonicNonNull;
import org.checkerframework.checker.nullness.qual.Nullable;
import org.spongepowered.api.scheduler.ScheduledUpdate;
import org.spongepowered.api.world.server.ServerLocation;
import org.spongepowered.api.world.server.ServerWorld;
import org.spongepowered.asm.mixin.Final;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
import org.spongepowered.common.accessor.world.ticks.LevelChunkTicksAccessor;
import org.spongepowered.common.bridge.CreatorTrackedBridge;
import org.spongepowered.common.bridge.data.DataCompoundHolder;
import org.spongepowered.common.bridge.data.SpongeDataHolderBridge;
import org.spongepowered.common.bridge.world.ticks.TickNextTickDataBridge;
import org.spongepowered.common.data.holder.SpongeMutableDataHolder;
import org.spongepowered.common.util.Preconditions;

import java.time.Duration;

@Mixin(ScheduledTick.class)
public abstract class ScheduledTickMixin<T> implements TickNextTickDataBridge<T> {
public abstract class ScheduledTickMixin<T> implements TickNextTickDataBridge<T>, SpongeMutableDataHolder, DataCompoundHolder, CreatorTrackedBridge {

@Shadow @Final private BlockPos pos;
@Shadow @Final private long triggerTick;
Expand All @@ -54,6 +64,8 @@ public abstract class ScheduledTickMixin<T> implements TickNextTickDataBridge<T>
private long impl$scheduledTime;
private ScheduledUpdate.State impl$state = ScheduledUpdate.State.WAITING;

private @Nullable CompoundTag impl$compound;

@Override
public void bridge$createdByList(final ServerLevel level, final LevelChunkTicks<T> levelChunkTicks) {
this.impl$parentLevelChunkTicks = levelChunkTicks;
Expand Down Expand Up @@ -99,5 +111,18 @@ public abstract class ScheduledTickMixin<T> implements TickNextTickDataBridge<T>
return Ticks.duration(this.triggerTick - this.impl$scheduledTime);
}

@Override
public CompoundTag data$getCompound() {
return this.impl$compound;
}

@Override
public void data$setCompound(final CompoundTag nbt) {
this.impl$compound = nbt;
}

@Inject(method = "toSavedTick", at = @At(value = "RETURN"))
private void impl$onToSaveSkipCancelled(final long $$0, final CallbackInfoReturnable<SavedTick<T>> cir) {
((SpongeDataHolderBridge) (Object) cir.getReturnValue()).bridge$mergeDeserialized(((SpongeDataHolderBridge) this).bridge$getManipulator());
}
}
Loading

0 comments on commit f913752

Please sign in to comment.