TeleportDuration Key for Display Entities #4020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aromaa
reviewed
Jun 2, 2024
There was a problem hiding this comment.
Looking at Minecraft's sources they seem to clamp this between 0 and 59 on serialization. Either we should do that too or serialize them internally separately.
In general, where is this useful? What can you do with this that is not possible with the transformation interpolation?
src/main/java/org/spongepowered/common/data/provider/entity/DisplayEntityData.java
Outdated
Show resolved
Hide resolved
testplugins/src/main/java/org/spongepowered/test/entity/DisplayEntityTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Joni Aromaa <[email protected]>
It is my understanding that Transformations don't actually move the entity. In this case the teleportation is explicitly moving the entity and interpolating it from one spot to the other. So with transformations you'd have to actively update the entities position to match behavior if I understand correctly. |
Faithcaio
pushed a commit
that referenced
this pull request
Jun 28, 2024
Faithcaio
pushed a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
teleport_durationwas added in MC 1.20.2SpongePowered/SpongeAPI#2508 | Sponge