Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Viewer#sendBlockProgress #4023

Closed
wants to merge 12 commits into from
Closed

Add Viewer#sendBlockProgress #4023

wants to merge 12 commits into from

Conversation

MrHell228
Copy link
Contributor

@MrHell228 MrHell228 commented Jun 2, 2024 •
edited
Loading

SpongeAPI | Sponge

  1. I think getting progress stage from progress should be done in some different place but I'm not sure which one
  2. Maybe SpongeServer#getOrCreateBlockDestructionId() should be changed to just SpongeServer#createBlockDestructionId()

@MrHell228 MrHell228 mentioned this pull request Jun 2, 2024
Merged
@MrHell228 MrHell228 mentioned this pull request Jun 23, 2024
Closed
8 tasks
@Faithcaio
Copy link
Contributor

squashed and rebased in dbe01ea

@Faithcaio Faithcaio closed this Jun 23, 2024
@MrHell228 MrHell228 deleted the api-11-cracks branch June 23, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faithcaio Faithcaio Faithcaio left review comments

@Yeregorix Yeregorix Yeregorix left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrHell228 @Faithcaio @Yeregorix