Move CODEOWNERS so it has an effect

[akx]

Quoth the documentation:

To use a CODEOWNERS file, create a new file called CODEOWNERS in the root, docs/, or .github/ directory of the repository, in the branch where you'd like to add the code owners.

A CODEOWNERS in .github/workflows has no effect AFAIU.

[palp]

Quoth the documentation:

To use a CODEOWNERS file, create a new file called CODEOWNERS in the root, docs/, or .github/ directory of the repository, in the branch where you'd like to add the code owners.

A CODEOWNERS in .github/workflows has no effect AFAIU.

Yep, this was misplaced, thanks. Intended to be in .github but root is fine.

[akx]

@palp Inference tests fail because externals such as yours truly don't have access to secrets (as is well and proper), so run: ln -s ${{secrets.SGM_CHECKPOINTS_PATH}} checkpoints ends up being just ln -s checkpoints:

For now, you may want to make the inference tests only run when the secret is available, with e.g.

if: github.repository == 'stability-ai/generative-models' && secrets.SGM_CHECKPOINTS_PATH

(syntax might not be exactly that, can't remember) in the job's if:.

[palp]

@palp Inference tests fail because externals such as yours truly don't have access to secrets (as is well and proper), so run: ln -s ${{secrets.SGM_CHECKPOINTS_PATH}} checkpoints ends up being just ln -s checkpoints:

For now, you may want to make the inference tests only run when the secret is available, with e.g.

if: github.repository == 'stability-ai/generative-models' && secrets.SGM_CHECKPOINTS_PATH

(syntax might not be exactly that, can't remember) in the job's if:.

This doesn't actually need to be secret, so now it's in vars; want to swap it here to make sure it works?

[akx]

@palp

This doesn't actually need to be secret, so now it's in vars; want to swap it here to make sure it works?

Erm..? (reference on main)

generative-models/.github/workflows/test-inference.yml

Line 18 in 931d7a3

run: ln -s ${{secrets.SGM_CHECKPOINTS_PATH}} checkpoints

[palp]

@palp

This doesn't actually need to be secret, so now it's in vars; want to swap it here to make sure it works?

Erm..? (reference on main)

generative-models/.github/workflows/test-inference.yml

Line 18 in 931d7a3

run: ln -s ${{secrets.SGM_CHECKPOINTS_PATH}} checkpoints

run: ln -s ${{vars.SGM_CHECKPOINTS_PATH}} checkpoints should work instead now

[akx]

@palp No dice on the CI change, same result.

[palp]

@palp No dice on the CI change, same result.

Ok, we can merge this, I'll deal with the CI issue.