Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multiple blockchains #64

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ShivamBisen
Copy link
Contributor

Related Issue:
Fixes #45.

Description:
Previously, FairFund smart contracts were only deployed on Polygon. This update extends support to multiple EVM-compatible blockchains, allowing deployments on:

Ethereum: Sepolia, Goerli
Polygon: Mumbai
Binance Smart Chain: BSC Testnet

Backend Changes:

Updated the Makefile to include deployment targets for Sepolia, Goerli, Mumbai, and BSC testnets.
Made changes to the HelperConfig.s.sol file to support multiple chains.

Front-End Changes:

Updated the Wagmi config to handle multiple chain IDs.

@adityabhattad2021
Copy link
Contributor

Polygon Mumbai is depricated, Binance Smart Chain is not needed.
Also Milkomeda would be a nice addition.

@ShivamBisen
Copy link
Contributor Author

I have made the suggested changes please review

Copy link
Contributor

@adityabhattad2021 adityabhattad2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go through the comments.

import { foundry, polygonAmoy, sepolia, goerli, AppKitNetwork } from '@reown/appkit/networks';


const milkomedaTestnet: AppKitNetwork = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is repeated code (used in siwe/index.ts as well, could you put in a seperate file and import it from there?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create a networks file and export milkomedaTestnet as Bruno mentioned in the community. I referred to Clowder for guidance, and this network configuration should work as expected.

package.json Outdated
},
"dependencies": {
"@wagmi/chains": "^1.8.0",
"@wagmi/core": "^2.16.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not required. I might have accidentally installed it. I will be careful from next time

@adityabhattad2021
Copy link
Contributor

adityabhattad2021 commented Feb 2, 2025

Ethereum Goerli is also deprecated.

@ShivamBisen
Copy link
Contributor Author

made required changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants