(ITE-146) Update Segment Engage Destination to handle onDelete events #11
+179
−324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const formattedExternalIds = `["${userId}"]` | ||
|
|
||
| const syncIds = [sha256hash(String(userId))] | ||
| const formattedSyncIds = `[${syncIds.map((syncId: string) => `"${syncId}"`).join(', ')}]` |
There was a problem hiding this comment.
If I understand correctly, we know that there will always only be one syncId, so why put it into an array and map it if the outcome will always just be "${syncId}"
There was a problem hiding this comment.
Yes that's correct, this was leftover logic from before, I will fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Segment Engage Destination to handle onDelete events
A logic rewrite after the new graphQL API.
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.