ci(workflow): standardize scripts command to stacks conventions

StackExchange · Mar 20, 2024 · 7fad17e · 7fad17e
1 parent 2cab473
commit 7fad17e
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 38 deletions.
diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -20,11 +20,8 @@ jobs:
             - name: Install dependencies
               run: npm ci
 
-            - name: Run ESLint
-              run: npm run lint:eslint
-
-            - name: Run Prettier validation
-              run: npm run lint:prettier
+            - name: Run Linters
+              run: npm run lint
     unit-test:
         runs-on: ubuntu-latest
         steps:
@@ -39,8 +36,8 @@ jobs:
             - name: Install dependencies
               run: npm ci
 
-            - name: Run tests
-              run: npm test
+            - name: Run unit tests
+              run: npm test:unit
     e2e-test:
         runs-on: ubuntu-latest
         steps:
@@ -62,7 +59,7 @@ jobs:
               run: npm run test:e2e
 
             - uses: actions/upload-artifact@v3
-              if: always()
+              if: failure()
               with:
                   name: playwright-test-results
                   path: test-results/

diff --git a/.prettierrc.mjs b/.prettierrc.mjs
@@ -0,0 +1,6 @@
+import config from "@stackoverflow/prettier-config";
+
+export default {
+    ...config,
+    endOfLine: "auto",
+};
diff --git a/package.json b/package.json
@@ -13,16 +13,16 @@
         "dist/"
     ],
     "scripts": {
-        "test": "jest --config config/jest-unit.config.js",
-        "test:e2e": "npx playwright test --config config/playwright.config.ts",
         "start": "webpack serve --config config/webpack.dev.js",
         "build": "webpack --config config/webpack.prod.js",
         "build:dev": "webpack --config config/webpack.dev.js",
         "build:gh-pages": "webpack --config config/webpack.dev.js --mode=production --",
-        "print-stats": "webpack --config config/webpack.prod.js --entry ./src/index.ts --profile --json > stats.json",
-        "lint:eslint": "eslint .",
-        "lint:prettier": "prettier --check . --end-of-line auto",
-        "lint:prettier:fix": "prettier --check . --end-of-line auto --write",
+        "build:stats": "webpack --config config/webpack.prod.js --entry ./src/index.ts --profile --json > stats.json",
+        "lint": "prettier --check . && eslint .",
+        "format": "prettier --write .",
+        "test": "npm run test:unit && npm run test:e2e",
+        "test:unit": "jest --config config/jest-unit.config.js",
+        "test:e2e": "npx playwright test --config config/playwright.config.ts",
         "release": "standard-version",
         "prepublishOnly": "npm run build && tsc --module ES6 --sourceMap false",
         "prepare": "husky install"
@@ -43,7 +43,6 @@
             "./config/.eslintrc.js"
         ]
     },
-    "prettier": "@stackoverflow/prettier-config",
     "devDependencies": {
         "@commitlint/cli": "^19.0.3",
         "@commitlint/config-conventional": "^18.6.2",