You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates Stacks Classic from 2.2.0 to 2.3.0 and makes updates to the markdown toggle to support the new button group styling.
@CGuindon when you have a sec, check out the deploy preview and let me know if it looks ok to you. The button padding needed to be tweaked, so if you'd like the button padding tweaked further let me know.
@dancormier if you are planning to cut a release for this soon I would recommend to merge this one liner from this PR as well. This is because there is a PR in Core that is using a release candidate version of the editor which might break things in case they merge it.
if you are planning to cut a release for this soon I would recommend to merge this one liner from this PR as well. This is because there is a PR in Core that is using a release candidate version of the editor which might break things in case they merge it.
@dancormier I think as part of this upgrade we should have probably bumped the stacks classic peer dependency version to ^2.3.0 in the package.json. I am assuming that the markup changes you made as part of this PR made UI using editor 0.10.4 and stacks classic 2.1.0 look a bit funky. Is that a correct assumption?
If yes, let's push to the main branch the adjustment of the peer dependency to stacks classic ^2.3.0. This way we will have the correct peer dependency version in the next editor release. Thank you. 😊
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Stacks Classic from 2.2.0 to 2.3.0 and makes updates to the markdown toggle to support the new button group styling.
@CGuindon when you have a sec, check out the deploy preview and let me know if it looks ok to you. The button padding needed to be tweaked, so if you'd like the button padding tweaked further let me know.
Once this is approved, I'll cut a new stacks-editor release with this change and update our Core PR for updating Stacks with it, which will resolve the button group issue mentioned there.