-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra_vars parsing directives due to Jinja #14
Open
cognifloyd
wants to merge
3
commits into
StackStorm-Exchange:master
Choose a base branch
from
cognifloyd:extra-vars-directives
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add extra_vars parsing directives due to Jinja #14
cognifloyd
wants to merge
3
commits into
StackStorm-Exchange:master
from
cognifloyd:extra-vars-directives
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried adding jinja2 filters, but that didn't help. In order to solve this in a more generic way, ST2 would need something similar to allow for type specification on the fly so that it can cast things to the appropriate type. Note that both this and #11 specify version 0.6.0. Whichever merges second will have to change to 0.7.0. |
798f922
to
b1e8b9a
Compare
Jinja always casts extra_vars to string because it is impossible to specify in a schema what vars might pass through extra_vars. So, to make it possible to pass objects through Jinja and have them show up as objects or ints or whatever, this adds directives with tests to show they work. The directives available are: '!INT', '!JSON', '!AST'. See the readme for how to use them.
b1e8b9a
to
1a7005e
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jinja always casts extra_vars to string because it is impossible to
specify in a schema what vars might pass through extra_vars. So, to make
it possible to pass objects through Jinja and have them show up as
objects or ints or whatever, this adds directives with tests to show
they work.
The directives available are: '!INT', '!JSON', '!AST'. See the readme
for how to use them.