Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Barrierefreiheitserklärung #115

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Barrierefreiheitserklärung #115

merged 5 commits into from
Mar 11, 2024

Conversation

maehr
Copy link
Member

@maehr maehr commented Mar 9, 2024 •
edited by coderabbitai bot
Loading

Pull request

Proposed changes

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Enhancement (non-breaking change which enhances functionality)
  • Bug Fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist

  • I have read the README document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Added a "Barrierefreiheit" (Accessibility) link in the navigation section for improved accessibility.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7a0b119

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 9, 2024 •
edited
Loading

Walkthrough

This change introduces a link for "Barrierefreiheit" in the navigation section, enhancing the website's accessibility features. This update aligns with the effort to make the site more inclusive and accessible to a broader audience by providing easier access to the accessibility statement directly from the main navigation.

Changes

File Change Summary
src/routes/+layout.svelte Added a link for "Barrierefreiheit" in navigation

Assessment against linked issues

Objective Addressed Explanation
Add Barrierefreiheitserklärung to footer (#104) ❌ The change was made to the navigation, not the footer as specified.

Related issues

  • feat: wcag 2.1 compliance #105: This issue could be linked because enhancing accessibility (e.g., adding a "Barrierefreiheit" link) is a step towards WCAG 2.1 compliance, which is the goal of this issue. However, the specific objectives listed in feat: wcag 2.1 compliance #105 are not directly addressed by this PR.

Poem

In the web's vast, open field, 🌐
A tiny change, its power wield.
"Barrierefreiheit" now in sight, 🌟
A beacon in the digital night.
For all to click, to learn, to see,
A step towards inclusivity.
🐰 CodeRabbit hops with glee!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@maehr maehr requested a review from mtwente March 9, 2024 15:11
coderabbitai[bot]
coderabbitai bot reviewed Mar 9, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e3a82df and 1ccb8f9.
Files selected for processing (1)
  • src/routes/+layout.svelte (1 hunks)
Additional comments: 1
src/routes/+layout.svelte (1)
  • 140-141: The addition of the "Barrierefreiheit" link in the footer section is correctly implemented and enhances the website's accessibility by providing easy access to the accessibility statement. This change aligns well with the PR's objectives and the website's commitment to inclusivity. The use of the "anchor" class for styling is consistent with other links in the footer, ensuring a uniform appearance. Overall, this change effectively addresses the objective outlined in issue Add Barrierefreiheitserklärung to footer #104.

coderabbitai[bot]
coderabbitai bot reviewed Mar 10, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 1ccb8f9 and 7875582.
Files selected for processing (1)
  • src/routes/+layout.svelte (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/routes/+layout.svelte

mtwente
mtwente requested changes Mar 11, 2024
View reviewed changes
src/routes/+layout.svelte Outdated Show resolved Hide resolved
coderabbitai[bot]
coderabbitai bot reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7875582 and a490c05.
Files selected for processing (1)
  • src/routes/+layout.svelte (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/routes/+layout.svelte

coderabbitai[bot]
coderabbitai bot reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a490c05 and 7a0b119.
Files selected for processing (1)
  • src/routes/+layout.svelte (5 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/routes/+layout.svelte

@maehr maehr merged commit 71766c5 into Stadt-Geschichte-Basel:main Mar 11, 2024
3 checks passed
@maehr maehr deleted the barriere_footer branch May 9, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@mtwente mtwente mtwente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Social media links not opening in new window Add Barrierefreiheitserklärung to footer
2 participants
@maehr @mtwente