fix: do not fail on 404 #62

maehr · 2024-01-25T13:47:33Z

Pull request

Proposed changes

Types of changes

New feature (non-breaking change which adds functionality).
Enhancement (non-breaking change which enhances functionality)
Bug Fix (non-breaking change which fixes an issue).
Breaking change (fix or feature that would cause existing functionality to change).

Checklist

I have read the README document.
My change requires a change to the documentation.
I have updated the documentation accordingly.

Summary by CodeRabbit

Refactor
- Updated SvelteKit project configuration to better handle build errors during prerendering.

changeset-bot · 2024-01-25T13:47:37Z

⚠️ No Changeset found

Latest commit: 0366da2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2024-01-25T13:47:40Z

Walkthrough

The update to the SvelteKit configuration involves a new prerendering feature. It allows the specification of how HTTP errors are handled during the build process, giving developers more control over the rendering behavior of their applications when encountering errors.

Changes

File	Change Summary
`svelte.config.js`	Added `prerender` property with updated settings to control build errors.

Poem

In the code where the bugs like to play,
A rabbit hopped through, making way.
🌟 With a tweak and a fix in the night,
🌙 Now the build sings a tune that's just right.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between c52619e and a5ee05f.

Files selected for processing (1)

svelte.config.js (1 hunks)

Additional comments: 1

svelte.config.js (1)

22-26: The addition of the prerender configuration with handleHttpError set to 'warn' is a good approach to handle 404 errors during the build process without failing the build. This change aligns with the PR's objective to handle 404 errors more gracefully.

cloudflare-workers-and-pages · 2024-01-25T13:48:31Z

Deploying with Cloudflare Pages

Latest commit:	`0366da2`
Status:	✅ Deploy successful!
Preview URL:	https://e7632d71.stadtgeschichtebasel-ch.pages.dev
Branch Preview URL:	https://404-fail.stadtgeschichtebasel-ch.pages.dev

View logs

koilebeit · 2024-01-25T16:52:17Z

there is also an "MissingID"-Error:
Error: The following pages contain links to /[https://www.dbsv.org/gendern.html#barrierefreiheit](https://www.dbsv.org/gendern.html#barrierefreiheit)\, but no element with id="barrierefreiheit](https://www.dbsv.org/gendern.html#barrierefreiheit)\" exists on /[https://www.dbsv.org/gendern.html - see the `handleMissingId` option in https://kit.svelte.dev/docs/configuration#prerender

Maybe the handleMissingId Option must be added?
prerender: { handleHttpError: 'warn', handleMissingID: 'warn' }

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between a5ee05f and 0366da2.

Files selected for processing (1)

svelte.config.js (1 hunks)

Additional comments: 1

svelte.config.js (1)

22-27: The addition of prerender: { handleHttpError: 'warn', handleMissingId: 'warn' } in the kit configuration is a good approach to handle 404 errors and missing IDs without failing the build process. This change aligns with the PR's objective to improve error handling. Ensure that the rest of the build and deployment pipeline can appropriately handle and log these warnings for further analysis.

fix: do not fail on 404

a5ee05f

maehr requested a review from koilebeit January 25, 2024 13:47

coderabbitai bot reviewed Jan 25, 2024

View reviewed changes

fix: add handleMissingId

0366da2

coderabbitai bot reviewed Jan 25, 2024

View reviewed changes

koilebeit approved these changes Jan 26, 2024

View reviewed changes

maehr merged commit d983bc6 into main Jan 26, 2024
5 checks passed

maehr deleted the 404-fail branch January 26, 2024 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: do not fail on 404 #62

fix: do not fail on 404 #62

maehr commented Jan 25, 2024 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jan 25, 2024 •

edited

Loading

coderabbitai bot commented Jan 25, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

coderabbitai bot left a comment

cloudflare-workers-and-pages bot commented Jan 25, 2024 •

edited

Loading

koilebeit commented Jan 25, 2024 •

edited

Loading

coderabbitai bot left a comment

fix: do not fail on 404 #62

fix: do not fail on 404 #62

Conversation

maehr commented Jan 25, 2024 • edited by coderabbitai bot Loading

Pull request

Proposed changes

Types of changes

Checklist

Summary by CodeRabbit

changeset-bot bot commented Jan 25, 2024 • edited Loading

⚠️ No Changeset found

coderabbitai bot commented Jan 25, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Jan 25, 2024 • edited Loading

Deploying with Cloudflare Pages

koilebeit commented Jan 25, 2024 • edited Loading

coderabbitai bot left a comment

Choose a reason for hiding this comment

maehr commented Jan 25, 2024 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jan 25, 2024 •

edited

Loading

coderabbitai bot commented Jan 25, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

cloudflare-workers-and-pages bot commented Jan 25, 2024 •

edited

Loading

koilebeit commented Jan 25, 2024 •

edited

Loading