Improve state handling

StanfordBDHG · Dec 3, 2024 · 9ec7d85 · 9ec7d85
1 parent 41ceb1d
commit 9ec7d85
Show file tree

Hide file tree

Showing 25 changed files with 433 additions and 1,501 deletions.
diff --git a/main.tsx b/main.tsx
@@ -21,6 +21,8 @@ const router = createRouter({
       entityName="page"
     />
   ),
+  defaultPendingMs: 300,
+  defaultPendingMinMs: 200,
 })
 
 declare module '@tanstack/react-router' {

diff --git a/modules/notifications/NotificationsTable/index.tsx b/modules/notifications/NotificationsTable/index.tsx
@@ -8,7 +8,7 @@
 
 import {
   DataTable,
-  DataTableBasicView,
+  type DataTableProps,
 } from '@stanfordspezi/spezi-web-design-system/components/DataTable'
 import { parseNilLocalizedText } from '@/modules/firebase/localizedText'
 import { type UserMessage } from '@/modules/firebase/models'
@@ -36,12 +36,14 @@ const columns = [
   }),
 ]
 
-interface NotificationsTableProps {
+interface NotificationsTableProps
+  extends Omit<DataTableProps<UserMessage>, 'data'> {
   notifications: UserMessage[]
 }
 
 export const NotificationsTable = ({
   notifications,
+  ...props
 }: NotificationsTableProps) => (
   <DataTable
     columns={columns}
@@ -57,18 +59,17 @@ export const NotificationsTable = ({
     initialState={{
       columnFilters: [{ id: columnIds.isRead, value: false }],
     }}
+    {...props}
   >
-    {(props) => (
-      <DataTableBasicView {...props}>
-        {(rows) =>
-          rows.map((row) => {
-            const notification = row.original
-            return (
-              <Notification key={notification.id} notification={notification} />
-            )
-          })
-        }
-      </DataTableBasicView>
+    {({ rows }) => (
+      <div>
+        {rows.map((row) => {
+          const notification = row.original
+          return (
+            <Notification key={notification.id} notification={notification} />
+          )
+        })}
+      </div>
     )}
   </DataTable>
 )