Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stories and tests covering new DataTable features #73

Merged

Conversation

arkadiuszbachorski
Copy link
Collaborator

Add stories and tests covering new DataTable features

♻️ Current situation & Problem

DataTable received couple features that were not covered before. This addresses that issue.

⚙️ Release Notes

  • Add stories and tests covering new DataTable features

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 87.23404% with 6 lines in your changes missing coverage. Please review.

Project coverage is 30.57%. Comparing base (5fad08e) to head (8066f80).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
modules/notifications/NotificationsTable/index.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   25.13%   30.57%   +5.44%     
==========================================
  Files         214      188      -26     
  Lines        7356     6603     -753     
  Branches      352      335      -17     
==========================================
+ Hits         1848     2018     +170     
+ Misses       5387     4497     -890     
+ Partials      121       88      -33     
Files with missing lines Coverage Δ
...system/src/components/DataTable/DataTable.mocks.ts 100.00% <100.00%> (ø)
...em/src/components/DataTable/DataTableBasicView.tsx 100.00% <100.00%> (+79.17%) ⬆️
modules/notifications/NotificationsTable/index.tsx 0.00% <0.00%> (ø)

... and 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e01da1...8066f80. Read the comment docs.

@arkadiuszbachorski arkadiuszbachorski merged commit cb7efa4 into main Oct 18, 2024
10 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/add-stories-and-tests-to-new-data-table branch October 18, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant