Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make invitation code readonly #89

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

arkadiuszbachorski
Copy link
Collaborator

Make invitation code readonly

♻️ Current situation & Problem

#88

⚙️ Release Notes

  • Remove invitation code from PatientForm
  • Add invitation code to user information

I moved the invitation code to the information panel on the left if it's meant to be read-only.

image

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 0.92%. Comparing base (c835211) to head (171756b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
routes/~_dashboard/patients/$id/UserActivity.tsx 0.00% 6 Missing ⚠️
routes/~_dashboard/~patients/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main     #89      +/-   ##
========================================
+ Coverage   0.92%   0.92%   +0.01%     
========================================
  Files         71      71              
  Lines       3602    3595       -7     
  Branches      80      80              
========================================
  Hits          33      33              
+ Misses      3502    3495       -7     
  Partials      67      67              
Files with missing lines Coverage Δ
routes/~_dashboard/~patients/PatientForm.tsx 0.00% <ø> (ø)
routes/~_dashboard/patients/$id/~index.tsx 0.00% <ø> (ø)
routes/~_dashboard/~patients/utils.ts 0.00% <0.00%> (ø)
routes/~_dashboard/patients/$id/UserActivity.tsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c835211...171756b. Read the comment docs.

Copy link
Contributor

@pauljohanneskraft pauljohanneskraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 😊 I'd still wait for @PSchmiedmayer to review, which is why I'm not approving myself.

@pauljohanneskraft pauljohanneskraft added the enhancement New feature or request label Nov 5, 2024
@pauljohanneskraft pauljohanneskraft linked an issue Nov 5, 2024 that may be closed by this pull request
1 task
@arkadiuszbachorski
Copy link
Collaborator Author

I'll merge it as it was approved on the meeting.

@arkadiuszbachorski arkadiuszbachorski merged commit 4707881 into main Nov 5, 2024
10 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/make-invitationc-code-readonly branch November 5, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Make invitationCode immutable
2 participants