Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symptom Upload & Local Storage of Uploaded ECG Recordings #48

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

PSchmiedmayer
Copy link
Member

Symptom Upload & Local Storage of Uploaded ECG Recordings

♻️ Current situation & Problem

  • Symptoms are currently not uploaded if they are recorded after the ECG is complete

⚙️ Release Notes

  • Symptom Upload
  • Local Storage of Uploaded ECG Recordings

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 220 lines in your changes are missing coverage. Please review.

Comparison is base (2ace230) 30.33% compared to head (ed062af) 28.26%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   30.33%   28.26%   -2.06%     
==========================================
  Files          33       34       +1     
  Lines        1118     1228     +110     
==========================================
+ Hits          339      347       +8     
- Misses        779      881     +102     
Files Coverage Δ
PAWS/Study Information/StudyDescription.swift 0.00% <0.00%> (ø)
PAWS/Study Information/StudyInformation.swift 15.00% <0.00%> (-0.78%) ⬇️
PAWS/ECGRecordings/ECGRecordingsList.swift 93.75% <66.67%> (+0.65%) ⬆️
PAWS/ECGRecordings/ECGRecording.swift 0.00% <0.00%> (ø)
PAWS/Contacts/Contacts.swift 66.30% <0.00%> (-9.34%) ⬇️
PAWS/ECGRecordings/ECGModule.swift 11.33% <9.62%> (-88.67%) ⬇️
PAWS/PAWSStandard.swift 3.59% <1.41%> (-0.35%) ⬇️
...rdings/HKElectrocardiogram+SupplementaryData.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ace230...ed062af. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 4458bfd into main Feb 21, 2024
6 of 7 checks passed
@PSchmiedmayer PSchmiedmayer deleted the symptomUpload branch February 21, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants