Specific Upload Error Handling #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
- Coverage 28.26% 28.17% -0.09%
==========================================
Files 34 34
Lines 1228 1232 +4
==========================================
Hits 347 347
- Misses 881 885 +4
Continue to review full report in Codecov by Sentry.
|
PSchmiedmayer
requested changes
Feb 26, 2024
There was a problem hiding this comment.
Thank you @MatthewTurk247; I added some first feedback in the PR 🚀
MatthewTurk247
commented
Feb 26, 2024
PSchmiedmayer
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific Upload Error Handling
♻️ Current situation & Problem
Previously, uploads of
HKQuantityTypeIdentifierPhysicalEffortwere throwing errors before the other samples could be uploaded.⚙️ Release Notes
Now that there is separation of concerns between computing properties of ECGs and uploading them, valid samples will still be successfully uploaded, even if other samples throw
HealthKitOnFHIR.HealthKitOnFHIRError.notSupported.📚 Documentation
Next steps will involve adding new support for some samples to HealthKitOnFHIR and updating the documentation of supported quantity sample types.
✅ Testing
Uploaded requests can be viewed in the Mock Web Service tab while debugging.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: