Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Date of Enrollment From the Firebase Instance #83

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

PSchmiedmayer
Copy link
Member

Load Date of Enrollment From the Firebase Instance

⚙️ Release Notes

  • Load the date of enrollment from the firebase instance to support the re-installation of the app & switching devices.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added bug Something isn't working enhancement New feature or request labels Jan 21, 2025
@PSchmiedmayer PSchmiedmayer self-assigned this Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 87.23404% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.51%. Comparing base (d66e09d) to head (7438c43).

Files with missing lines Patch % Lines
PAWS/ECGRecordings/ECGModule.swift 78.27% 10 Missing ⚠️
PAWS/Account/AccountSheet.swift 33.34% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   81.34%   81.51%   +0.17%     
==========================================
  Files          34       35       +1     
  Lines        1254     1319      +65     
==========================================
+ Hits         1020     1075      +55     
- Misses        234      244      +10     
Files with missing lines Coverage Δ
PAWS/Account/DateOfEnrollment.swift 100.00% <100.00%> (ø)
PAWS/ECGRecordings/ECGRecordingsList.swift 100.00% <100.00%> (ø)
PAWS/Helper/Firestore+User.swift 92.31% <ø> (ø)
PAWS/Onboarding/AccountOnboarding.swift 90.00% <100.00%> (+1.12%) ⬆️
PAWS/Onboarding/Consent.swift 94.12% <ø> (-0.32%) ⬇️
PAWS/PAWSDelegate.swift 96.20% <100.00%> (+0.08%) ⬆️
PAWS/PAWSStandard.swift 62.91% <100.00%> (+1.89%) ⬆️
PAWS/Account/AccountSheet.swift 66.67% <33.34%> (-3.60%) ⬇️
PAWS/ECGRecordings/ECGModule.swift 69.88% <78.27%> (+1.41%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d66e09d...7438c43. Read the comment docs.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

PAWS/PAWSDelegate.swift Fixed Show fixed Hide fixed
@PSchmiedmayer
Copy link
Member Author

@aydinzahedi Fixed the ECG issues we have been talking about a while ago.

@vishnuravi Might be great if you can double-check the changes in this PR to ensure that we don't introduce any active bugs in the ongoing study.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant