Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some small oversights #29

Merged
merged 5 commits into from
Jan 29, 2025
Merged

fix some small oversights #29

merged 5 commits into from
Jan 29, 2025

Conversation

lukaskollmer
Copy link
Member

@lukaskollmer lukaskollmer commented Jan 28, 2025

fix some small oversights

♻️ Current situation & Problem

#27 included a couple of small oversights, which this PR will fix

  • restore edu.stanford bundle ID and development team
  • adjust some readme headings
  • fix some symbol links in the documentation

closes #28

⚙️ Release Notes

n/a

📚 Documentation

n/a

✅ Testing

n/a

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.38%. Comparing base (90575b7) to head (b7eda6e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   71.38%   71.38%           
=======================================
  Files          42       42           
  Lines        2372     2372           
=======================================
  Hits         1693     1693           
  Misses        679      679           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90575b7...b7eda6e. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the improvements! Happy to see it merged once the link checks are resolved (if they are not false positives).

@PSchmiedmayer PSchmiedmayer added the documentation Improvements or additions to documentation label Jan 29, 2025
@lukaskollmer
Copy link
Member Author

@PSchmiedmayer my understanding is that the link issues will continue until we create a non-beta release (i didn't try every single link it complains about but i did try some, and the issue simply is that SPI currently still redirects them to the docs for the 0.6.0 release, but if i manually replace the tag with the 1.0.0-beta.1 release, they work fine)

@PSchmiedmayer
Copy link
Member

Ok, sounds fair, we will have to live with that for a bit. Would be kind of cool to see the SPI support beta tags, also applies to repos like grocSwift and others as well. We might want to create an issue for that in the future.

But for now, I am happy to see the PR merged in its current state 👍

@lukaskollmer
Copy link
Member Author

@PSchmiedmayer feel free to merge this.

i have some more changes upcoming (as part of integrating SpeziHealthKit into the upcoming study features, but that'll be a separate PR)

@PSchmiedmayer PSchmiedmayer merged commit 1650f93 into main Jan 29, 2025
8 of 9 checks passed
@PSchmiedmayer PSchmiedmayer deleted the lukas/fix-oversights branch January 29, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Upate README
2 participants