-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some small oversights #29
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage 71.38% 71.38%
=======================================
Files 42 42
Lines 2372 2372
=======================================
Hits 1693 1693
Misses 679 679 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the improvements! Happy to see it merged once the link checks are resolved (if they are not false positives).
@PSchmiedmayer my understanding is that the link issues will continue until we create a non-beta release (i didn't try every single link it complains about but i did try some, and the issue simply is that SPI currently still redirects them to the docs for the |
Ok, sounds fair, we will have to live with that for a bit. Would be kind of cool to see the SPI support beta tags, also applies to repos like grocSwift and others as well. We might want to create an issue for that in the future. But for now, I am happy to see the PR merged in its current state 👍 |
@PSchmiedmayer feel free to merge this. i have some more changes upcoming (as part of integrating SpeziHealthKit into the upcoming study features, but that'll be a separate PR) |
fix some small oversights
♻️ Current situation & Problem
#27 included a couple of small oversights, which this PR will fix
closes #28
⚙️ Release Notes
n/a
📚 Documentation
n/a
✅ Testing
n/a
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: