Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix currently taking and medications that might help sections #176

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

eldcn
Copy link
Contributor

@eldcn eldcn commented Jan 27, 2025

Currently taking and medications that might help sections

♻️ Current situation & Problem

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 40.71%. Comparing base (0e0d806) to head (77e189d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...h/engagehf/medication/components/MedicationCard.kt 0.00% 7 Missing ⚠️
.../medication/data/MedicationRecommendationMapper.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #176      +/-   ##
============================================
+ Coverage     40.71%   40.71%   +0.01%     
+ Complexity      866      863       -3     
============================================
  Files           299      299              
  Lines         11434    11430       -4     
  Branches       1723     1722       -1     
============================================
- Hits           4654     4653       -1     
+ Misses         6319     6316       -3     
  Partials        461      461              
Flag Coverage Δ
uitests 35.98% <ø> (ø)
unittests 32.10% <46.67%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gagehf/medication/data/MedicationRecommendation.kt 97.15% <100.00%> (ø)
...rd/bdh/engagehf/medication/ui/MedicationUiState.kt 96.88% <100.00%> (ø)
.../engagehf/medication/ui/MedicationUiStateMapper.kt 78.17% <100.00%> (-2.52%) ⬇️
.../medication/data/MedicationRecommendationMapper.kt 65.72% <75.00%> (+8.96%) ⬆️
...h/engagehf/medication/components/MedicationCard.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e0d806...77e189d. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this @eldcn!

@PSchmiedmayer PSchmiedmayer added enhancement New feature or request ENGAGE HF ENGAGE-HF-specific issues labels Jan 27, 2025
@eldcn eldcn merged commit 29f28ae into main Jan 28, 2025
11 checks passed
@eldcn eldcn deleted the task/issue-156 branch January 28, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENGAGE HF ENGAGE-HF-specific issues enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Medications incorrectly labeled when the patient is not taking them
2 participants