Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profiling, remove unnecessary CI steps #1009

Open
wants to merge 2 commits into
base: og-develop
Choose a base branch
from
Open

Fix profiling, remove unnecessary CI steps #1009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3f0a7d
Update all CI runs to not use omnigibson-src directory.
cgokmen Oct 24, 2024
0c330ba
Merge branch 'og-develop' into fix-profiling
cgokmen Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions .github/workflows/examples-as-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,18 @@ jobs:
shell: micromamba run -n omnigibson /bin/bash -leo pipefail {0}
steps:
- name: Checkout source
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
submodules: true
path: omnigibson-src

- name: Install
working-directory: omnigibson-src
run: pip install -e .[dev]

- name: Generate example tests
working-directory: omnigibson-src
run: python tests/create_tests_of_examples.py

- name: Get list of generated tests
id: get-test-list
working-directory: omnigibson-src
run: |
echo "example_tests=$(cat tests/example_tests.json)" >> $GITHUB_OUTPUT

Expand Down Expand Up @@ -69,17 +65,14 @@ jobs:
run: echo "HOME=/root" >> $GITHUB_ENV

- name: Checkout source
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
submodules: true
path: omnigibson-src

- name: Install
working-directory: omnigibson-src
run: pip install -e .[dev]

- name: Run tests
working-directory: omnigibson-src
run: pytest -s tests/tests_of_examples/${{ matrix.test_file }}.py --junitxml=${{ matrix.test_file }}.xml && cp ${{ matrix.test_file }}.xml ${GITHUB_WORKSPACE}/

- name: Deploy artifact
Expand All @@ -99,20 +92,12 @@ jobs:
shell: micromamba run -n omnigibson /bin/bash -leo pipefail {0}
needs: [run_test]
steps:
- name: Checkout source
uses: actions/checkout@v2
with:
submodules: true
path: omnigibson-src
- name: Pull reports
uses: actions/download-artifact@v3
with:
path: omnigibson-src
- name: Example Test Report0
uses: dorny/test-reporter@v1
with:
name: Example Test Results
working-directory: omnigibson-src
path: ${{ github.run_id }}-tests-*/*_test.xml
reporter: java-junit
fail-on-error: 'true'
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/profiling.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,9 @@ jobs:
run: echo "HOME=/root" >> $GITHUB_ENV

- name: Checkout source
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install
working-directory: omnigibson-src
run: pip install -e .[dev]

- name: Run performance benchmark
Expand Down
13 changes: 1 addition & 12 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,17 @@ jobs:

steps:
- name: Checkout source
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
submodules: true
path: omnigibson-src

- name: Install
working-directory: omnigibson-src
run: pip install -e .[dev]

- name: Print env
run: printenv

- name: Run tests
working-directory: omnigibson-src
run: pytest -s tests/${{ matrix.test_file }}.py --junitxml=${{ matrix.test_file }}.xml && cp ${{ matrix.test_file }}.xml ${GITHUB_WORKSPACE}/
continue-on-error: true

Expand Down Expand Up @@ -89,20 +86,12 @@ jobs:
needs: [run_test]
if: always()
steps:
- name: Checkout source
uses: actions/checkout@v2
with:
submodules: true
path: omnigibson-src
- name: Pull reports
uses: actions/download-artifact@v3
with:
path: omnigibson-src
- name: Test Report0
uses: dorny/test-reporter@v1
with:
name: Test Results
working-directory: omnigibson-src
path: ${{ github.run_id }}-tests-*/test_*.xml
reporter: java-junit
fail-on-error: 'false'
Expand Down
Loading