Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/25 race w model #27

Merged
merged 4 commits into from
Mar 28, 2017
Merged

Issues/25 race w model #27

merged 4 commits into from
Mar 28, 2017

Conversation

tomalec
Copy link
Contributor

@tomalec tomalec commented Mar 27, 2017

Implements solution 1. from #25 (comment)

starcounter-include should wait with attaching model until, new content is effectively loaded.

@tomalec tomalec requested a review from warpech March 27, 2017 03:21
warpech
warpech approved these changes Mar 27, 2017
View reviewed changes
Copy link
Contributor

@warpech warpech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the solid rewrite of the tests. The tests are passing for me (tested on Mac Chrome, FF and Safari)

@tomalec tomalec merged commit ff51cc0 into master Mar 28, 2017
@tomalec tomalec deleted the issues/25-race-w-model branch March 29, 2017 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warpech warpech warpech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomalec @warpech